fix directory traversal

salinas-miguel · salinas-miguel · commit 786e906a0eae · 2021-10-01T17:40:19.000-07:00
diff --git a/tools/swift-stdlib-tool/swift-stdlib-tool.cpp b/tools/swift-stdlib-tool/swift-stdlib-tool.cpp
@@ -888,7 +888,7 @@ void enumerateDirectory(std::string directory, F&& func) {
             func(path);
         } else if (entry->d_type == DT_DIR) {
             // check if . or ..
-            if (strncmp(entry->d_name, "..", entry->d_namlen)) {
+            if (strncmp(entry->d_name, "..", entry->d_namlen) == 0) {
                 continue;
             }
             enumerateDirectory(path, func);

Original file line number	Diff line number	Diff line change
`@@ -888,7 +888,7 @@ void enumerateDirectory(std::string directory, F&& func) {`
`888`	`888`	`func(path);`
`889`	`889`	`} else if (entry->d_type == DT_DIR) {`
`890`	`890`	`// check if . or ..`
`891`		`- if (strncmp(entry->d_name, "..", entry->d_namlen)) {`
	`891`	`+ if (strncmp(entry->d_name, "..", entry->d_namlen) == 0) {`
`892`	`892`	`continue;`
`893`	`893`	`}`
`894`	`894`	`enumerateDirectory(path, func);`