@@ -2028,18 +2028,18 @@ bool swift::diagnoseUnintendedObjCMethodOverrides(SourceFile &sf) {
2028
2028
// Diagnose the override.
2029
2029
auto methodDiagInfo = getObjCMethodDiagInfo (method);
2030
2030
auto overriddenDiagInfo = getObjCMethodDiagInfo (overriddenMethod);
2031
- Ctx.Diags .diagnose (method, diag::objc_override_other,
2032
- methodDiagInfo.first ,
2033
- methodDiagInfo.second ,
2034
- overriddenDiagInfo.first ,
2035
- overriddenDiagInfo.second ,
2036
- selector,
2037
- overriddenMethod->getDeclContext ()
2038
- ->getDeclaredInterfaceType ());
2031
+
2032
+ Ctx.Diags .diagnose (
2033
+ method, diag::objc_override_other, methodDiagInfo.first ,
2034
+ methodDiagInfo.second , overriddenDiagInfo.first ,
2035
+ overriddenDiagInfo.second , method->getObjCSelector (),
2036
+ overriddenMethod->getDeclContext ()->getDeclaredInterfaceType ());
2037
+
2039
2038
const ValueDecl *overriddenDecl = overriddenMethod;
2040
2039
if (overriddenMethod->isImplicit ())
2041
2040
if (auto accessor = dyn_cast<AccessorDecl>(overriddenMethod))
2042
2041
overriddenDecl = accessor->getStorage ();
2042
+
2043
2043
Ctx.Diags .diagnose (overriddenDecl, diag::objc_declared_here,
2044
2044
overriddenDiagInfo.first , overriddenDiagInfo.second );
2045
2045
@@ -2143,12 +2143,9 @@ bool swift::diagnoseObjCMethodConflicts(SourceFile &sf) {
2143
2143
Ctx.Diags .diagnose (originalDecl, diag::invalid_redecl_prev,
2144
2144
originalDecl->getBaseName ());
2145
2145
} else {
2146
- Ctx.Diags .diagnose (conflictingDecl, diag::objc_redecl,
2147
- diagInfo.first ,
2148
- diagInfo.second ,
2149
- origDiagInfo.first ,
2150
- origDiagInfo.second ,
2151
- selector);
2146
+ Ctx.Diags .diagnose (conflictingDecl, diag::objc_redecl, diagInfo.first ,
2147
+ diagInfo.second , origDiagInfo.first ,
2148
+ origDiagInfo.second , selector);
2152
2149
Ctx.Diags .diagnose (originalDecl, diag::objc_declared_here,
2153
2150
origDiagInfo.first , origDiagInfo.second );
2154
2151
}
0 commit comments