Merge pull request #81037 from aschwaighofer/irgen_coroFrameAlloc_cleanup

IRGen: Centralize logic that decides whether the platform suppports typed malloc

Author: aschwaighofer

lib/Frontend/CompilerInvocation.cpp

@@ -3781,10 +3781,15 @@ static bool ParseIRGenArgs(IRGenOptions &Opts, ArgList &Args,
     Args.hasFlag(OPT_enable_async_frame_push_pop_metadata,
                  OPT_disable_async_frame_push_pop_metadata,
                  Opts.EmitAsyncFramePushPopMetadata);
+
+  bool platformSupportsTypedMalloc = !llvm::Triple(Triple).isOSLinux() &&
+    !llvm::Triple(Triple).isOSWindows();
+
   Opts.EmitTypeMallocForCoroFrame =
   Args.hasFlag(OPT_enable_emit_type_malloc_for_coro_frame,
               OPT_disable_emit_type_malloc_for_coro_frame,
-              Opts.EmitTypeMallocForCoroFrame);
+              (Opts.EmitTypeMallocForCoroFrame && platformSupportsTypedMalloc));
+
   Opts.AsyncFramePointerAll = Args.hasFlag(OPT_enable_async_frame_pointer_all,
                                            OPT_disable_async_frame_pointer_all,
                                            Opts.AsyncFramePointerAll);

lib/IRGen/GenCall.cpp

@@ -5117,9 +5117,7 @@ void irgen::emitYieldOnceCoroutineEntry(
   auto *buffer = emission.getCoroutineBuffer();
   llvm::SmallVector<llvm::Value *, 2> finalArgs;
   llvm::Constant *allocFn = nullptr;
-  if (IGF.getOptions().EmitTypeMallocForCoroFrame
-      && !llvm::Triple(IGF.IGM.Triple).isOSLinux()
-      && !llvm::Triple(IGF.IGM.Triple).isOSWindows()) {
+  if (IGF.getOptions().EmitTypeMallocForCoroFrame) {
     auto mallocTypeId = IGF.getMallocTypeId();
     finalArgs.push_back(mallocTypeId);
     // Use swift_coroFrameAllocStub to emit our allocator.

lib/IRGen/GenFunc.cpp

@@ -1499,9 +1499,7 @@ class CoroPartialApplicationForwarderEmission
     // Call the right 'llvm.coro.id.retcon' variant.
     llvm::Value *buffer = origParams.claimNext();
     llvm::Value *id;
-    if (subIGF.IGM.getOptions().EmitTypeMallocForCoroFrame
-        && !llvm::Triple(subIGF.IGM.Triple).isOSLinux()
-        && !llvm::Triple(subIGF.IGM.Triple).isOSWindows()) {
+    if (subIGF.IGM.getOptions().EmitTypeMallocForCoroFrame) {
       // Use swift_coroFrameAllocStub to emit our allocator.
       auto coroAllocFn = subIGF.IGM.getOpaquePtr(getCoroFrameAllocStubFn(subIGF.IGM));
       auto mallocTypeId = subIGF.getMallocTypeId();