Merge pull request #81053 from slavapestov/fix-rdar149315905-6.2

[6.2] Workaround for performance regression with opaque archetypes

Author: slavapestov

lib/AST/TypeSubstitution.cpp

@@ -329,7 +329,7 @@ class TypeSubstituter : public TypeTransform<TypeSubstituter> {
   std::optional<Type> transformLocalArchetypeType(LocalArchetypeType *local,
                                                   TypePosition pos);
 
-  SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
+  // SubstitutionMap transformSubstitutionMap(SubstitutionMap subs);
 
   CanType transformSILField(CanType fieldTy, TypePosition pos);
 };
@@ -446,10 +446,13 @@ Type TypeSubstituter::transformDependentMemberType(DependentMemberType *dependen
   return conformance.getTypeWitness(substBase, assocType, IFS.getOptions());
 }
 
+// FIXME: This exposes a scalability issue; see test/SILGen/opaque_result_type_slow.swift.
+/*
 SubstitutionMap TypeSubstituter::transformSubstitutionMap(SubstitutionMap subs) {
   // FIXME: Take level into account? Move level down into IFS?
   return subs.subst(IFS);
 }
+*/
 
 CanType TypeSubstituter::transformSILField(CanType fieldTy, TypePosition pos) {
   // Type substitution does not walk into the SILBoxType's field types, because

test/SILGen/Inputs/opaque_result_type_slow_other.swift

@@ -0,0 +1,8 @@
+public protocol P {}
+public protocol Q {}
+
+public func wrap<T: P & Q>(_ t: T) -> some P & Q {
+  return t
+}
+
+

test/SILGen/opaque_result_type_slow.swift

@@ -0,0 +1,32 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -emit-module %S/Inputs/opaque_result_type_slow_other.swift -emit-module -emit-module-path %t/opaque_result_type_slow_other.swiftmodule -enable-library-evolution
+// RUN: %target-swift-emit-silgen %s -I %t
+
+import opaque_result_type_slow_other
+
+struct G<T: P & Q>: P & Q {}
+
+public func myWrap<T: P & Q>(_ t: T) -> some P & Q {
+  return G<T>()
+}
+
+public func wrapWrap<T: P & Q>(_ t: T) -> some P & Q {
+  return wrap(wrap(myWrap(t)))
+}
+
+public struct S: P, Q {}
+
+// We generate a series of substitution maps where each one contains an opaque archetype,
+// and an abstract conformance of this opaque archetype to a protocol. Each opaque archetype
+// then has a substitution map of the same form, and so on.
+//
+// Transforming each substitution map then visits each opaque archetype twice: once as part
+// of the replacement type, and again as part of the conformance.
+//
+// What saves us is that we would skip the conformance substitution in some cases, and perform
+// a lookup instead. This lookup is now load bearing, because changing it into a substitution
+// makes this program intractably slow.
+//
+// The correct fix is to probably cache substituted opaque GenericEnvironments, or
+// substituted SubstitutionMaps, inside of the InFlightSubstitution.
+let x = wrapWrap(wrapWrap(wrapWrap(wrapWrap(wrapWrap(wrapWrap(wrapWrap(wrapWrap(wrapWrap(S())))))))))