Skip to content

Commit 7eab80a

Browse files
ktosoktoso
committed
[Distributed] Link missing feature FIXME's with radar number
1 parent 75c5133 commit 7eab80a

6 files changed

+15
-15
lines changed

‎test/Distributed/Runtime/distributed_actor_func_calls_remoteCall_through_generic.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// RUN: %empty-directory(%t)
22
// RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift
33
// RUN: %target-build-swift -module-name main -Xfrontend -disable-availability-checking -j2 -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift -o %t/a.out
4-
// RUN: %target-run %t/a.out | %FileCheck %s --color --dump-input=always
4+
// RUN: %target-run %t/a.out | %FileCheck %s --color
55

66
// REQUIRES: executable_test
77
// REQUIRES: concurrency

‎test/Distributed/distributed_actor_inference.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ protocol DP {
4242
}
4343

4444
protocol DPOK: DistributedActor {
45-
distributed func hello() // FIXME(distributed): not possible today...
45+
distributed func hello() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
4646
// expected-error@-1{{'distributed' protocol requirement 'hello()' must currently be declared explicitly 'async throws'}}
4747
}
4848

4949
protocol DPOK2: DPOK {
50-
distributed func again() // FIXME(distributed): not possible today...
50+
distributed func again() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
5151
// expected-error@-1{{'distributed' protocol requirement 'again()' must currently be declared explicitly 'async throws'}}
5252
}
5353

‎test/Distributed/distributed_actor_protocol_isolation.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,17 @@ protocol MixedProtoDistributedActor: DistributedActor {
3737
func localThrows() throws
3838
func localAsyncThrows() async throws
3939

40-
// distributed func dist() // FIXME(distributed): not possible today...
41-
// distributed func distAsync() async // FIXME(distributed): not possible today...
40+
// distributed func dist() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
41+
// distributed func distAsync() async // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
4242
distributed func distAsyncThrows() async throws
4343
}
4444

4545
protocol DistProtoDistributedActor: DistributedActor {
46-
distributed func dist() // FIXME(distributed): not possible today...
46+
distributed func dist() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
4747
// expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
48-
distributed func distAsync() async // FIXME(distributed): not possible today...
48+
distributed func distAsync() async // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
4949
// expected-error@-1{{'distributed' protocol requirement 'distAsync()' must currently be declared explicitly 'async throws'}}
50-
distributed func distThrows() throws // FIXME(distributed): not possible today...
50+
distributed func distThrows() throws // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
5151
// expected-error@-1{{'distributed' protocol requirement 'distThrows()' must currently be declared explicitly 'async throws'}}
5252
distributed func distAsyncThrows() async throws
5353
}

‎test/Distributed/distributed_protocol_isolation.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ protocol DistProtocol: DistributedActor {
2525
// expected-note@-3{{distributed actor-isolated instance method 'local()' declared here}}
2626
// expected-note@-4{{distributed actor-isolated instance method 'local()' declared here}}
2727

28-
distributed func dist() -> String // FIXME(distributed): not possible today...
28+
distributed func dist() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
2929
// expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
30-
distributed func dist(string: String) -> String // FIXME(distributed): not possible today...
30+
distributed func dist(string: String) -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
3131
// expected-error@-1{{'distributed' protocol requirement 'dist(string:)' must currently be declared explicitly 'async throws'}}
3232

33-
distributed func distAsync() async -> String // FIXME(distributed): not possible today...
33+
distributed func distAsync() async -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
3434
// expected-error@-1{{'distributed' protocol requirement 'distAsync()' must currently be declared explicitly 'async throws'}}
35-
distributed func distThrows() throws -> String // FIXME(distributed): not possible today...
35+
distributed func distThrows() throws -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
3636
// expected-error@-1{{'distributed' protocol requirement 'distThrows()' must currently be declared explicitly 'async throws'}}
3737
distributed func distAsyncThrows() async throws -> String
3838
}
@@ -257,7 +257,7 @@ func test_watchingDA_any(da: any TerminationWatchingDA) async throws {
257257
// MARK: Error cases
258258

259259
protocol ErrorCases: DistributedActor {
260-
distributed func unexpectedAsyncThrows() -> String // FIXME(distributed): not possible today...
260+
distributed func unexpectedAsyncThrows() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
261261
// expected-error@-1{{'distributed' protocol requirement 'unexpectedAsyncThrows()' must currently be declared explicitly 'async throws'}}
262262
// expected-note@-2{{protocol requires function 'unexpectedAsyncThrows()' with type '() -> String'; do you want to add a stub?}}
263263
}

‎test/Distributed/distributed_protocols_distributed_func_serialization_requirements.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import FakeDistributedActorSystems
1010
struct NotCodable {}
1111

1212
protocol NoSerializationRequirementYet: DistributedActor {
13-
distributed func test() -> NotCodable // FIXME(distributed): not possible today...
13+
distributed func test() -> NotCodable // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
1414
// expected-error@-1{{'distributed' protocol requirement 'test()' must currently be declared explicitly 'async throws'}}
1515

1616
// OK, no serialization requirement yet

‎test/decl/protocol/special/DistributedActor.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ distributed actor D4 {
6464
}
6565

6666
protocol P1: DistributedActor {
67-
distributed func dist() -> String // FIXME(distributed): not possible today...
67+
distributed func dist() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
6868
// expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
6969
// expected-note@-2{{'dist()' declared here}}
7070
}

0 commit comments

Comments
 (0)