Merge pull request #11726 from slavapestov/fix-unused-warnings

Gardening: Fix unused variable warnings

Author: slavapestov

lib/AST/DeclContext.cpp

@@ -658,7 +658,7 @@ unsigned DeclContext::getSyntacticDepth() const {
 
 unsigned DeclContext::getSemanticDepth() const {
   // For extensions, count the depth of the nominal type being extended.
-  if (auto ext = dyn_cast<ExtensionDecl>(this)) {
+  if (isa<ExtensionDecl>(this)) {
     if (auto nominal = getAsNominalTypeOrNominalTypeExtensionContext())
       return nominal->getSemanticDepth();
 

lib/ClangImporter/ImportDecl.cpp

@@ -5346,7 +5346,7 @@ Decl *SwiftDeclConverter::importGlobalAsMethod(
               dc->getAsNominalTypeOrNominalTypeExtensionContext()) {
         if (auto clangDCTy = dyn_cast_or_null<clang::TypedefNameDecl>(
                 nominalTypeDecl->getClangDecl()))
-          if (auto newtypeAttr = getSwiftNewtypeAttr(clangDCTy, getVersion()))
+          if (getSwiftNewtypeAttr(clangDCTy, getVersion()))
             if (clangDCTy->getUnderlyingType().getCanonicalType() !=
                 selfParamTy->getPointeeType().getCanonicalType())
               selfIsInOut = false;

lib/SILGen/SILGenBridging.cpp

@@ -941,7 +941,7 @@ static ManagedValue emitCBridgedToNativeValue(SILGenFunction &SGF,
   }
 
   // Bridge Objective-C to thick metatypes.
-  if (auto nativeMetaTy = dyn_cast<AnyMetatypeType>(nativeType)) {
+  if (isa<AnyMetatypeType>(nativeType)) {
     auto bridgedMetaTy = cast<AnyMetatypeType>(bridgedType);
     if (bridgedMetaTy->hasRepresentation() &&
         bridgedMetaTy->getRepresentation() == MetatypeRepresentation::ObjC) {

lib/SILOptimizer/Mandatory/AccessEnforcementSelection.cpp

@@ -255,7 +255,7 @@ void SelectEnforcement::analyzeProjection(ProjectBoxInst *projection) {
 
       continue;
     }
-    if (auto *PAI = dyn_cast<PartialApplyInst>(user))
+    if (isa<PartialApplyInst>(user))
       Captures.emplace_back(AddressCapture(*use));
   }
 }

lib/SILOptimizer/Utils/Local.cpp

@@ -1517,7 +1517,7 @@ optimizeBridgedObjCToSwiftCast(SILInstruction *Inst,
   auto *AI = Builder.createApply(Loc, FuncRef, Subs, Args, false);
 
   // If the source of a cast should be destroyed, emit a release.
-  if (auto *UCCAI = dyn_cast<UnconditionalCheckedCastAddrInst>(Inst)) {
+  if (isa<UnconditionalCheckedCastAddrInst>(Inst)) {
     Builder.createReleaseValue(Loc, SrcOp, Builder.getDefaultAtomicity());
   }
 

lib/Sema/CSDiag.cpp

@@ -2465,7 +2465,7 @@ diagnoseTypeMemberOnInstanceLookup(Type baseObjTy,
       Diag.emplace(diagnose(loc,
                             diag::assoc_type_outside_of_protocol,
                             ATD->getName()));
-    } else if (auto CD = dyn_cast<ConstructorDecl>(member)) {
+    } else if (isa<ConstructorDecl>(member)) {
       Diag.emplace(diagnose(loc,
                             diag::construct_protocol_by_name,
                             metatypeTy->getInstanceType()));
@@ -5508,13 +5508,13 @@ static bool isRawRepresentableMismatch(Type fromType, Type toType,
   // First check if this is an attempt to convert from something to
   // raw representable.
   if (conformsToKnownProtocol(fromType, kind, CS)) {
-    if (auto rawType = isRawRepresentable(toType, kind, CS))
+    if (isRawRepresentable(toType, kind, CS))
       return true;
   }
 
   // Otherwise, it might be an attempt to convert from raw representable
   // to its raw value.
-  if (auto rawType = isRawRepresentable(fromType, kind, CS)) {
+  if (isRawRepresentable(fromType, kind, CS)) {
     if (conformsToKnownProtocol(toType, kind, CS))
       return true;
   }