Skip to content

Commit 7f51163

Browse files
committed
[cmake] Remove manual setting of include_directories for LLVM include dirs.
LLVM already provides these directories via the LLVMConfig.cmake variable LLVM_INCLUDE_DIRS, which we are already using to import those directories. Thus this work is and even worse gives the illusion that we are not delegating the computation of LLVM's include paths to LLVM (which is really what we are doing and should be doing). rdar://26154980
1 parent 3168df8 commit 7f51163

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

cmake/modules/SwiftSharedCMakeConfig.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ macro(swift_common_standalone_build_config_llvm product is_cross_compiling)
8484
"${PACKAGE_VERSION_MAJOR}.${PACKAGE_VERSION_MINOR}" CACHE STRING
8585
"Version number that will be placed into the libclang library , in the form XX.YY")
8686

87-
include_directories("${PATH_TO_LLVM_BUILD}/include"
88-
"${LLVM_MAIN_INCLUDE_DIR}")
8987
foreach (INCLUDE_DIR ${LLVM_INCLUDE_DIRS})
9088
include_directories(${INCLUDE_DIR})
9189
endforeach ()

0 commit comments

Comments
 (0)