Merge pull request #16357 from xedin/space-engine-dump-gardening

xedin · web-flow · commit 7fa201657514 · 2018-05-03T15:28:12.000-07:00
[Sema] NFC: Usage `llvm::errs()` directly in `SpaceEngine::dump`
diff --git a/lib/Sema/TypeCheckSwitchStmt.cpp b/lib/Sema/TypeCheckSwitchStmt.cpp
@@ -1827,8 +1827,6 @@ void TypeChecker::checkSwitchExhaustiveness(const SwitchStmt *stmt,
 }
 
 void SpaceEngine::Space::dump() const {
-  SmallString<128> buf;
-  llvm::raw_svector_ostream os(buf);
-  this->show(os, /*normalize*/false);
-  llvm::errs() << buf.str();
+  this->show(llvm::errs(), /*normalize*/ false);
+  llvm::errs() << '\n';
 }

Original file line number	Diff line number	Diff line change
`@@ -1827,8 +1827,6 @@ void TypeChecker::checkSwitchExhaustiveness(const SwitchStmt *stmt,`
`1827`	`1827`	`}`
`1828`	`1828`
`1829`	`1829`	`void SpaceEngine::Space::dump() const {`
`1830`		`- SmallString<128> buf;`
`1831`		`- llvm::raw_svector_ostream os(buf);`
`1832`		`- this->show(os, /normalize/false);`
`1833`		`- llvm::errs() << buf.str();`
	`1830`	`+ this->show(llvm::errs(), /normalize/ false);`
	`1831`	`+ llvm::errs() << '\n';`
`1834`	`1832`	`}`