Merge pull request #15977 from hartbit/compiler-directive

New compiler directive to replace _compiler_version

Author: tkremenek

lib/Parse/ParseIfConfig.cpp

@@ -278,7 +278,8 @@ class ValidateIfConfigCondition :
     }
 
     // 'swift' '(' '>=' float-literal ( '.' integer-literal )* ')'
-    if (*KindName == "swift") {
+    // 'compiler' '(' '>=' float-literal ( '.' integer-literal )* ')'
+    if (*KindName == "swift" || *KindName == "compiler") {
       auto PUE = dyn_cast<PrefixUnaryExpr>(Arg);
       llvm::Optional<StringRef> PrefixName = PUE ?
         getDeclRefStr(PUE->getFn(), DeclRefKind::PrefixOperator) : None;
@@ -445,13 +446,18 @@ class EvaluateIfConfigCondition :
           Str, SourceLoc(), nullptr).getValue();
       auto thisVersion = version::Version::getCurrentCompilerVersion();
       return thisVersion >= Val;
-    } else if (KindName == "swift") {
+    } else if ((KindName == "swift") || (KindName == "compiler")) {
       auto PUE = cast<PrefixUnaryExpr>(Arg);
       auto Str = extractExprSource(Ctx.SourceMgr, PUE->getArg());
       auto Val = version::Version::parseVersionString(
           Str, SourceLoc(), nullptr).getValue();
-      auto thisVersion = Ctx.LangOpts.EffectiveLanguageVersion;
-      return thisVersion >= Val;
+      if (KindName == "swift") {
+        return Ctx.LangOpts.EffectiveLanguageVersion >= Val;  
+      } else if (KindName == "compiler") {
+        return version::Version::getCurrentLanguageVersion() >= Val;
+      } else {
+        llvm_unreachable("unsupported version conditional");
+      }
     } else if (KindName == "canImport") {
       auto Str = extractExprSource(Ctx.SourceMgr, Arg);
       return Ctx.canImportModule({ Ctx.getIdentifier(Str) , E->getLoc()  });
@@ -539,7 +545,8 @@ class IsVersionIfConfigCondition :
 
   bool visitCallExpr(CallExpr *E) {
     auto KindName = getDeclRefStr(E->getFn());
-    return KindName == "_compiler_version" || KindName == "swift";
+    return KindName == "_compiler_version" || KindName == "swift" ||
+        KindName == "compiler";
   }
 
   bool visitPrefixUnaryExpr(PrefixUnaryExpr *E) { return visit(E->getArg()); }

test/Compatibility/conditional_compiliation_expr.swift renamed to test/Compatibility/conditional_compilation_expr.swift

@@ -69,47 +69,95 @@ foo bar
 let _: Int = 1
 #endif
 
+#if !compiler(>=4.1)
+// There should be no error here.
+foo bar
+#else
+let _: Int = 1
+#endif
+
 #if (swift(>=2.2))
 let _: Int = 1
 #else
 // There should be no error here.
 foo bar
 #endif
 
+#if (compiler(>=4.1))
+let _: Int = 1
+#else
+// There should be no error here.
+foo bar
+#endif
+
 #if swift(>=99.0) || swift(>=88.1.1)
 // There should be no error here.
 foo bar baz // expected-error 2 {{consecutive statements}}
 #else
 undefinedElse() // expected-error {{use of unresolved identifier 'undefinedElse'}}
 #endif
 
+#if compiler(>=99.0) || compiler(>=88.1.1)
+// There should be no error here.
+foo bar baz // expected-error 2 {{consecutive statements}}
+#else
+undefinedElse() // expected-error {{use of unresolved identifier 'undefinedElse'}}
+#endif
+
 #if swift(>=99.0) || FOO
 undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
 #else
 undefinedElse()
 #endif
 
+#if compiler(>=99.0) || FOO
+undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
+#else
+undefinedElse()
+#endif
+
 #if swift(>=99.0) && FOO
 // There should be no error here.
 foo bar baz // expected-error 2 {{consecutive statements}}
 #else
 undefinedElse() // expected-error {{use of unresolved identifier 'undefinedElse'}}
 #endif
 
+#if compiler(>=99.0) && FOO
+// There should be no error here.
+foo bar baz // expected-error 2 {{consecutive statements}}
+#else
+undefinedElse() // expected-error {{use of unresolved identifier 'undefinedElse'}}
+#endif
+
 #if FOO && swift(>=2.2)
 undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
 #else
 // There should be no error here.
 foo bar baz // expected-error 2 {{consecutive statements}}
 #endif
 
+#if FOO && compiler(>=4.0)
+undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
+#else
+// There should be no error here.
+foo bar baz // expected-error 2 {{consecutive statements}}
+#endif
+
 #if swift(>=2.2) && swift(>=1)
 undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
 #else
 // There should be no error here.
 foo bar baz // expected-error 2 {{consecutive statements}}
 #endif
 
+#if compiler(>=4.1) && compiler(>=4)
+undefinedIf() // expected-error {{use of unresolved identifier 'undefinedIf'}}
+#else
+// There should be no error here.
+foo bar baz // expected-error 2 {{consecutive statements}}
+#endif
+
 // ---------------------------------------------------------------------------
 // SR-4031: Compound name in compilation condition
 // See test/Parse/ConditionalCompilation/compoundName_swift4.swift for Swfit 4 behavior