Skip to content

Commit 817c549

Browse files
committed
[lsan] Split the preset for lsan into stdlib -O and -Onone presets.
The current lsan preset used by the bot assumes -O. This is incorrect since: 1. It is a currently known problem that the -O build of swift leaks in the optimizer on linux. 2. The point of the bot is to ensure that when compiling the stdlib at -Onone, we are leaks clean. For more information about the bot see below. Once this lands, I will update the bot to use the new split preset. rdar://32876901 ---- For those who are unaware, I spent some time investigating and resolving the leaks at -Onone b/c SourceKit for diagnostic purposes compiles sources at -Onone, so the leaks could have hit SourceKit. Since SourceKit is a long running process this could add up over time/etc.
1 parent 753c961 commit 817c549

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

utils/build-presets.ini

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,8 @@ build-subdir=buildbot_incremental_asan
900900

901901
enable-asan
902902

903-
[preset: buildbot_incremental_linux,lsan]
903+
# This does not currently pass due to leakers in the optimizer.
904+
[preset: buildbot_incremental_linux,lsan,tools=RDA,stdlib=RDA,test=no]
904905
build-subdir=buildbot_incremental_lsan
905906

906907
release-debuginfo
@@ -912,6 +913,19 @@ dash-dash
912913
build-ninja
913914
reconfigure
914915

916+
[preset: buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no]
917+
build-subdir=buildbot_incremental_lsan
918+
919+
release-debuginfo
920+
assertions
921+
enable-lsan
922+
debug-swift-stdlib
923+
924+
dash-dash
925+
926+
build-ninja
927+
reconfigure
928+
915929
#===------------------------------------------------------------------------===#
916930
# OS X Package Builders
917931
#===------------------------------------------------------------------------===#

0 commit comments

Comments
 (0)