[gardening] Remove never-read variable bestPrev. Courtesy of clang-tidy.

gottesmm · gottesmm · commit 81d75e350813 · 2016-12-06T23:14:13.000-08:00
diff --git a/lib/IRGen/LocalTypeData.cpp b/lib/IRGen/LocalTypeData.cpp
@@ -97,7 +97,7 @@ llvm::Value *LocalTypeDataCache::tryGet(IRGenFunction &IGF, Key key,
   if (it == Map.end()) return nullptr;
   auto &chain = it->second;
 
-  CacheEntry *best = nullptr, *bestPrev = nullptr;
+  CacheEntry *best = nullptr;
   Optional<unsigned> bestCost;
 
   CacheEntry *next = chain.Root, *nextPrev = nullptr;
@@ -130,7 +130,6 @@ llvm::Value *LocalTypeDataCache::tryGet(IRGenFunction &IGF, Key key,
       bestCost = curCost;
     }
     best = cur;
-    bestPrev = curPrev;
   }
 
   // If we didn't find anything, we're done.

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ llvm::Value *LocalTypeDataCache::tryGet(IRGenFunction &IGF, Key key,`
`97`	`97`	`if (it == Map.end()) return nullptr;`
`98`	`98`	`auto &chain = it->second;`
`99`	`99`
`100`		`- CacheEntry best = nullptr, bestPrev = nullptr;`
	`100`	`+ CacheEntry *best = nullptr;`
`101`	`101`	`Optional<unsigned> bestCost;`
`102`	`102`
`103`	`103`	`CacheEntry next = chain.Root, nextPrev = nullptr;`
`@@ -130,7 +130,6 @@ llvm::Value *LocalTypeDataCache::tryGet(IRGenFunction &IGF, Key key,`
`130`	`130`	`bestCost = curCost;`
`131`	`131`	`}`
`132`	`132`	`best = cur;`
`133`		`- bestPrev = curPrev;`
`134`	`133`	`}`
`135`	`134`
`136`	`135`	`// If we didn't find anything, we're done.`