Skip to content

Commit 83aaccc

Browse files
committed
remove the "array.copy_into_vector" array-semantic
It's not needed anymore, because the "FixedArray" experimental feature is replaced by inline-arrays.
1 parent c6da889 commit 83aaccc

File tree

5 files changed

+1
-6
lines changed

5 files changed

+1
-6
lines changed

include/swift/AST/SemanticAttrs.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ SEMANTICS_ATTR(ARRAY_DEALLOC_UNINITIALIZED, "array.dealloc_uninitialized")
6464
SEMANTICS_ATTR(ARRAY_UNINITIALIZED_INTRINSIC, "array.uninitialized_intrinsic")
6565
SEMANTICS_ATTR(ARRAY_FINALIZE_INTRINSIC, "array.finalize_intrinsic")
6666
SEMANTICS_ATTR(ARRAY_GET_CONTIGUOUSARRAYSTORAGETYPE, "array.getContiguousArrayStorageType")
67-
SEMANTICS_ATTR(ARRAY_COPY_INTO_VECTOR, "array.copy_into_vector")
6867

6968
SEMANTICS_ATTR(SEQUENCE_FOR_EACH, "sequence.forEach")
7069
SEMANTICS_ATTR(TYPENAME, "typeName")

include/swift/SILOptimizer/Analysis/ArraySemantic.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ enum class ArrayCallKind {
3737
kWithUnsafeMutableBufferPointer,
3838
kAppendContentsOf,
3939
kAppendElement,
40-
kCopyIntoVector,
4140
// The following two semantic function kinds return the result @owned
4241
// instead of operating on self passed as parameter. If you are adding
4342
// a function, and it has a self parameter, make sure that it is defined
@@ -46,7 +45,7 @@ enum class ArrayCallKind {
4645
kArrayInitEmpty,
4746
kArrayUninitialized,
4847
kArrayUninitializedIntrinsic,
49-
kArrayFinalizeIntrinsic,
48+
kArrayFinalizeIntrinsic
5049
};
5150

5251
/// Return true is the given function is an array semantics call.

lib/SILOptimizer/Analysis/ArraySemantic.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ ArrayCallKind swift::getArraySemanticsKind(SILFunction *f) {
5353
ArrayCallKind::kWithUnsafeMutableBufferPointer)
5454
.Case("array.append_contentsOf", ArrayCallKind::kAppendContentsOf)
5555
.Case("array.append_element", ArrayCallKind::kAppendElement)
56-
.Case("array.copy_into_vector", ArrayCallKind::kCopyIntoVector)
5756
.Default(ArrayCallKind::kNone);
5857
if (Tmp != ArrayCallKind::kNone) {
5958
assert(Kind == ArrayCallKind::kNone && "Multiple array semantic "

lib/SILOptimizer/LoopTransforms/COWArrayOpt.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ static bool isNonMutatingArraySemanticCall(SILInstruction *Inst) {
321321
case ArrayCallKind::kGetElement:
322322
case ArrayCallKind::kGetElementAddress:
323323
case ArrayCallKind::kEndMutation:
324-
case ArrayCallKind::kCopyIntoVector:
325324
return true;
326325
case ArrayCallKind::kMakeMutable:
327326
case ArrayCallKind::kMutateUnknown:

lib/SILOptimizer/Utils/PerformanceInlinerUtils.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,6 @@ SemanticFunctionLevel swift::getSemanticFunctionLevel(SILFunction *function) {
632632
// transient and should be inlined away immediately.
633633
case ArrayCallKind::kArrayUninitializedIntrinsic:
634634
case ArrayCallKind::kArrayFinalizeIntrinsic:
635-
case ArrayCallKind::kCopyIntoVector:
636635
return SemanticFunctionLevel::Transient;
637636

638637
} // end switch

0 commit comments

Comments
 (0)