Skip to content

Commit 83cc98d

Browse files
committed
Fix python build scripts
1 parent 54aff1e commit 83cc98d

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

utils/build-script

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,11 @@ class HostSpecificConfiguration(object):
206206
self.swift_test_run_targets.append(
207207
"check-swift{}-optimize_size-{}".format(
208208
subset_suffix, name))
209-
if args.test_optimize_none_implicit_dynamic and not test_host_only:
209+
if args.test_optimize_none_implicit_dynamic and \
210+
not test_host_only:
210211
self.swift_test_run_targets.append(
211-
"check-swift{}-optimize_none_implicit_dynamic-{}".format(
212-
subset_suffix, name))
212+
"check-swift{}-optimize_none_implicit_dynamic-{}"
213+
.format(subset_suffix, name))
213214

214215

215216
class BuildScriptInvocation(object):

utils/build_swift/driver_arguments.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -748,11 +748,11 @@ def create_argument_parser():
748748

749749
# FIXME: Convert to store_true action
750750
option('-y', store('test_optimize_none_implicit_dynamic', const=True),
751-
help='run the test suite in optimize none with implicit dynamic mode'
752-
' too (implies --test)')
751+
help='run the test suite in optimize none with implicit dynamic'
752+
' mode too (implies --test)')
753753
option('--test-optimize-none-implicit-dynamic', toggle_true,
754-
help='run the test suite in optimize none with implicit dynamic mode'
755-
' too (implies --test)')
754+
help='run the test suite in optimize none with implicit dynamic'
755+
'mode too (implies --test)')
756756

757757
option('--long-test', toggle_true,
758758
help='run the long test suite')

utils/build_swift/tests/expected_options.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,8 @@ class IgnoreOption(_BaseOption):
452452
EnableOption('--stress-test'),
453453
EnableOption('--test'),
454454
EnableOption('--test-optimize-for-size'),
455+
EnableOption('--test-optimize-none-implicit-dynamic'),
456+
EnableOption('--test-optimized'),
455457
EnableOption('--test-optimized'),
456458
EnableOption('--tvos'),
457459
EnableOption('--validation-test'),

utils/build_swift/tests/test_driver_arguments.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -640,9 +640,10 @@ def test_implied_defaults_test_optimize_for_size(self):
640640
namespace = self.parse_default_args(['--test-optimize-for-size'])
641641
self.assertTrue(namespace.test)
642642

643-
def test_implied_defaults_test_optimize_for_size(self):
643+
def test_implied_defaults_test_optimize_none_implicit_dynamic(self):
644644
with self.assertNotRaises(ParserError):
645-
namespace = self.parse_default_args(['--test-optimize-none-implicit-dynamic'])
645+
namespace = self.parse_default_args(
646+
['--test-optimize-none-implicit-dynamic'])
646647
self.assertTrue(namespace.test)
647648

648649
def test_implied_defaults_skip_all_tests(self):

0 commit comments

Comments
 (0)