[TF] Fix Tensor.replacing(_:_:) wrong semantics. (#24635)

artste · rxwei · commit 847282327eda · 2019-05-18T04:04:18.000-07:00
Swapped `self` and `other`. Now values will be replaced if mask is `true`.
diff --git a/stdlib/public/TensorFlow/Ops.swift b/stdlib/public/TensorFlow/Ops.swift
@@ -972,7 +972,7 @@ public extension Tensor {
                   vjp: _vjpReplacing where Scalar : TensorFlowFloatingPoint)
   func replacing(with other: Tensor,
                  where mask: Tensor<Bool>) -> Tensor {
-    return Raw.select(condition: mask, t: self, e: other)
+    return Raw.select(condition: mask, t: other, e: self)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -972,7 +972,7 @@ public extension Tensor {`
`972`	`972`	`vjp: _vjpReplacing where Scalar : TensorFlowFloatingPoint)`
`973`	`973`	`func replacing(with other: Tensor,`
`974`	`974`	`where mask: Tensor<Bool>) -> Tensor {`
`975`		`- return Raw.select(condition: mask, t: self, e: other)`
	`975`	`+ return Raw.select(condition: mask, t: other, e: self)`
`976`	`976`	`}`
`977`	`977`	`}`
`978`	`978`