[stdlib] _SetBuilder, _DictionaryBuilder: Assume target has enough capacity

lorentey · lorentey · commit 84d8cedaaea8 · 2018-10-05T12:33:25.000+01:00
The compiled code included unnecessary references to resize().
diff --git a/stdlib/public/core/DictionaryBuilder.swift b/stdlib/public/core/DictionaryBuilder.swift
@@ -30,7 +30,9 @@ struct _DictionaryBuilder<Key: Hashable, Value> {
 
   @inlinable
   public mutating func add(key newKey: Key, value: Value) {
-    _target.insertNew(key: newKey, value: value)
+    _precondition(_target.count < _requestedCount,
+      "Can't add more members than promised")
+    _target._unsafeInsertNew(key: newKey, value: value)
   }
 
   @inlinable
diff --git a/stdlib/public/core/SetBuilder.swift b/stdlib/public/core/SetBuilder.swift
@@ -29,10 +29,11 @@ struct _SetBuilder<Element: Hashable> {
   }
 
   @inlinable
+  @inline(__always)
   public mutating func add(member: Element) {
     _precondition(_target.count < _requestedCount,
       "Can't add more members than promised")
-    _target.insertNew(member, isUnique: true)
+    _target._unsafeInsertNew(member)
   }
 
   @inlinable

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,9 @@ struct _DictionaryBuilder<Key: Hashable, Value> {`
`30`	`30`
`31`	`31`	`@inlinable`
`32`	`32`	`public mutating func add(key newKey: Key, value: Value) {`
`33`		`- _target.insertNew(key: newKey, value: value)`
	`33`	`+ _precondition(_target.count < _requestedCount,`
	`34`	`+ "Can't add more members than promised")`
	`35`	`+ _target._unsafeInsertNew(key: newKey, value: value)`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`@inlinable`
Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,11 @@ struct _SetBuilder<Element: Hashable> {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`@inlinable`
	`32`	`+ @inline(__always)`
`32`	`33`	`public mutating func add(member: Element) {`
`33`	`34`	`_precondition(_target.count < _requestedCount,`
`34`	`35`	`"Can't add more members than promised")`
`35`		`- _target.insertNew(member, isUnique: true)`
	`36`	`+ _target._unsafeInsertNew(member)`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`@inlinable`