Verify counts in ArraySlice and ContiguousArray too

Catfish-Man · Catfish-Man · commit 858caeca0fdd · 2024-11-11T16:29:47.000-08:00
diff --git a/stdlib/public/core/ArraySlice.swift b/stdlib/public/core/ArraySlice.swift
@@ -967,7 +967,8 @@ extension ArraySlice: RangeReplaceableCollection {
                 start: startNewElements,
                 count: self.capacity - oldCount)
 
-    _ = buf.initialize(fromContentsOf: newElements)
+    let end = buf.initialize(fromContentsOf: newElements)
+    _precondition(end == buf.endIndex)
     _buffer.count += newElementsCount
   }
 
diff --git a/stdlib/public/core/ContiguousArray.swift b/stdlib/public/core/ContiguousArray.swift
@@ -860,7 +860,8 @@ extension ContiguousArray: RangeReplaceableCollection {
                 start: startNewElements,
                 count: _buffer.mutableCapacity - oldCount)
 
-    _ = buf.initialize(fromContentsOf: newElements)
+    let end = buf.initialize(fromContentsOf: newElements)
+    _precondition(end == buf.endIndex)
     _buffer.count += newElementsCount
   }
 

Original file line number	Diff line number	Diff line change
`@@ -967,7 +967,8 @@ extension ArraySlice: RangeReplaceableCollection {`
`967`	`967`	`start: startNewElements,`
`968`	`968`	`count: self.capacity - oldCount)`
`969`	`969`
`970`		`- _ = buf.initialize(fromContentsOf: newElements)`
	`970`	`+ let end = buf.initialize(fromContentsOf: newElements)`
	`971`	`+ _precondition(end == buf.endIndex)`
`971`	`972`	`_buffer.count += newElementsCount`
`972`	`973`	`}`
`973`	`974`
Original file line number	Diff line number	Diff line change
`@@ -860,7 +860,8 @@ extension ContiguousArray: RangeReplaceableCollection {`
`860`	`860`	`start: startNewElements,`
`861`	`861`	`count: _buffer.mutableCapacity - oldCount)`
`862`	`862`
`863`		`- _ = buf.initialize(fromContentsOf: newElements)`
	`863`	`+ let end = buf.initialize(fromContentsOf: newElements)`
	`864`	`+ _precondition(end == buf.endIndex)`
`864`	`865`	`_buffer.count += newElementsCount`
`865`	`866`	`}`
`866`	`867`