Skip to content

Commit 8599292

Browse files
authored
Merge pull request #73616 from apple/egorzhdan/vwt-test-fix-old-macos
[cxx-interop] Fix a test on older macOS versions
2 parents ebaa184 + 8f8a242 commit 8599292

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

test/Interop/Cxx/foreign-reference/Inputs/witness-table.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ CxxLinkedList * _Nonnull makeLinkedList() {
3232

3333
struct __attribute__((swift_attr("import_reference")))
3434
__attribute__((swift_attr("retain:immortal")))
35-
__attribute__((swift_attr("release:immortal"))) CxxSequence {
35+
__attribute__((swift_attr("release:immortal"))) MyCxxSequence {
3636
CxxLinkedList * _Nullable list = nullptr;
3737

3838
CxxLinkedList * _Nullable next() {
@@ -45,14 +45,14 @@ __attribute__((swift_attr("release:immortal"))) CxxSequence {
4545
}
4646
};
4747

48-
CxxSequence * _Nonnull makeSequence() {
48+
MyCxxSequence * _Nonnull makeSequence() {
4949
CxxLinkedList *buff = (CxxLinkedList *)malloc(sizeof(CxxLinkedList) * 4);
5050
buff[0].value = 0;
5151
buff[1].value = 1;
5252
buff[2].value = 2;
5353
buff[3].value = 3;
5454

55-
CxxSequence *seq = (CxxSequence *)malloc(sizeof(CxxSequence));
55+
MyCxxSequence *seq = (MyCxxSequence *)malloc(sizeof(MyCxxSequence));
5656
seq->list = buff;
5757
return seq;
5858
}

test/Interop/Cxx/foreign-reference/witness-table.swift

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %target-run-simple-swift(-I %S/Inputs/ -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none -Xfrontend -disable-llvm-verify -Xfrontend -disable-availability-checking -g)
1+
// RUN: %target-run-simple-swift(-I %S/Inputs/ -Xfrontend -enable-experimental-cxx-interop -Xfrontend -validate-tbd-against-ir=none -Xfrontend -disable-llvm-verify -g)
22
//
33
// REQUIRES: executable_test
44
// XFAIL: OS=windows-msvc
@@ -26,8 +26,14 @@ public struct List<NodeType: ListNode> : Sequence, IteratorProtocol
2626
}
2727
}
2828

29+
@available(SwiftStdlib 5.8, *)
2930
extension CxxLinkedList : ListNode { }
3031

32+
@available(SwiftStdlib 5.8, *)
33+
extension MyCxxSequence : Sequence, IteratorProtocol { }
34+
35+
if #available(SwiftStdlib 5.8, *) {
36+
3137
var WitnessTableTestSuite = TestSuite("Use foreign reference in a generic context")
3238

3339
WitnessTableTestSuite.test("As generic argument to List") {
@@ -41,8 +47,6 @@ WitnessTableTestSuite.test("As generic argument to List") {
4147
expectEqual(count, 4)
4248
}
4349

44-
extension CxxSequence : Sequence, IteratorProtocol { }
45-
4650
WitnessTableTestSuite.test("As a Sequence") {
4751
let list = makeSequence()
4852
var count = 0
@@ -53,5 +57,7 @@ WitnessTableTestSuite.test("As a Sequence") {
5357
expectEqual(count, 3)
5458
}
5559

60+
}
61+
5662
runAllTests()
5763

0 commit comments

Comments
 (0)