Skip to content

Commit 859dabd

Browse files
authored
Merge pull request #68809 from kubamracek/embedded-sdk
[embedded] Resolve empty -sdk path warning in embedded stdlib build
2 parents 1470023 + 1b1db05 commit 859dabd

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

stdlib/cmake/modules/SwiftSource.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ function(_add_target_variant_swift_compile_flags
230230
${ARGN})
231231

232232
# On Windows, we don't set SWIFT_SDK_WINDOWS_PATH_ARCH_{ARCH}_PATH, so don't include it.
233-
if (NOT "${sdk}" STREQUAL "WINDOWS")
233+
if ((NOT "${sdk}" STREQUAL "WINDOWS") AND NOT ("${SWIFT_SDK_${sdk}_ARCH_${arch}_PATH}" STREQUAL ""))
234234
list(APPEND result "-sdk" "${SWIFT_SDK_${sdk}_ARCH_${arch}_PATH}")
235235
endif()
236236

stdlib/public/core/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,14 +420,15 @@ if(SWIFT_SHOULD_BUILD_EMBEDDED_STDLIB)
420420

421421
set(SWIFT_SDK_embedded_ARCH_${arch}_MODULE "${mod}")
422422
set(SWIFT_SDK_embedded_LIB_SUBDIR "embedded")
423+
set(SWIFT_SDK_embedded_ARCH_${arch}_TRIPLE "${triple}")
423424
add_swift_target_library_single(
424425
embedded-stdlib-${triple}
425426
swiftCore
426427
ONLY_SWIFTMODULE
427428
IS_STDLIB IS_STDLIB_CORE
428429
${SWIFTLIB_EMBEDDED_SOURCES}
429430
GYB_SOURCES ${SWIFTLIB_EMBEDDED_GYB_SOURCES}
430-
SWIFT_COMPILE_FLAGS -target "${triple}" -Xcc -D__MACH__ -enable-experimental-feature Embedded
431+
SWIFT_COMPILE_FLAGS -Xcc -D__MACH__ -enable-experimental-feature Embedded
431432
MODULE_DIR "${CMAKE_BINARY_DIR}/lib/swift/embedded"
432433
SDK "embedded"
433434
ARCHITECTURE "${arch}"

0 commit comments

Comments
 (0)