Merge pull request #455 from frootloops/uniform-random

gribozavr · gribozavr · commit 87bd89161d90 · 2015-12-21T23:36:50.000-08:00
FIXME: swift/validation-test/stdlib/Set.swift:95
diff --git a/validation-test/stdlib/Set.swift b/validation-test/stdlib/Set.swift
@@ -93,8 +93,7 @@ func helperDeleteThree(k1: TestKeyTy, _ k2: TestKeyTy, _ k3: TestKeyTy) {
 }
 
 func uniformRandom(max: Int) -> Int {
-  // FIXME: this is not uniform.
-  return random() % max
+  return Int(arc4random_uniform(UInt32(max)))
 }
 
 func pickRandom<T>(a: [T]) -> T {

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,7 @@ func helperDeleteThree(k1: TestKeyTy, _ k2: TestKeyTy, _ k3: TestKeyTy) {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`func uniformRandom(max: Int) -> Int {`
`96`		`- // FIXME: this is not uniform.`
`97`		`- return random() % max`
	`96`	`+ return Int(arc4random_uniform(UInt32(max)))`
`98`	`97`	`}`
`99`	`98`
`100`	`99`	`func pickRandom<T>(a: [T]) -> T {`