Skip to content

Commit 87cbb31

Browse files
committed
build: duplicate and rename the _add_variant_* functions
This allows us to start splitting up the swift and C/C++ specific paths.
1 parent b7654f1 commit 87cbb31

File tree

4 files changed

+449
-18
lines changed

4 files changed

+449
-18
lines changed

cmake/modules/AddSwift.cmake

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function(is_darwin_based_sdk sdk_name out_var)
7272
endfunction()
7373

7474
# Usage:
75-
# _add_variant_c_compile_link_flags(
75+
# _add_host_variant_c_compile_link_flags(
7676
# SDK sdk
7777
# ARCH arch
7878
# BUILD_TYPE build_type
@@ -86,7 +86,7 @@ endfunction()
8686
# DEPLOYMENT_VERSION_WATCHOS version
8787
#
8888
# )
89-
function(_add_variant_c_compile_link_flags)
89+
function(_add_host_variant_c_compile_link_flags)
9090
set(oneValueArgs SDK ARCH BUILD_TYPE RESULT_VAR_NAME ENABLE_LTO ANALYZE_CODE_COVERAGE
9191
DEPLOYMENT_VERSION_OSX DEPLOYMENT_VERSION_MACCATALYST DEPLOYMENT_VERSION_IOS DEPLOYMENT_VERSION_TVOS DEPLOYMENT_VERSION_WATCHOS
9292
MACCATALYST_BUILD_FLAVOR
@@ -189,7 +189,7 @@ function(_add_variant_c_compile_link_flags)
189189
endfunction()
190190

191191

192-
function(_add_variant_c_compile_flags)
192+
function(_add_host_variant_c_compile_flags)
193193
set(oneValueArgs SDK ARCH BUILD_TYPE ENABLE_ASSERTIONS ANALYZE_CODE_COVERAGE
194194
DEPLOYMENT_VERSION_OSX DEPLOYMENT_VERSION_MACCATALYST DEPLOYMENT_VERSION_IOS DEPLOYMENT_VERSION_TVOS DEPLOYMENT_VERSION_WATCHOS
195195
RESULT_VAR_NAME ENABLE_LTO
@@ -202,7 +202,7 @@ function(_add_variant_c_compile_flags)
202202

203203
set(result ${${CFLAGS_RESULT_VAR_NAME}})
204204

205-
_add_variant_c_compile_link_flags(
205+
_add_host_variant_c_compile_link_flags(
206206
SDK "${CFLAGS_SDK}"
207207
ARCH "${CFLAGS_ARCH}"
208208
BUILD_TYPE "${CFLAGS_BUILD_TYPE}"
@@ -363,7 +363,7 @@ function(_add_variant_c_compile_flags)
363363
set("${CFLAGS_RESULT_VAR_NAME}" "${result}" PARENT_SCOPE)
364364
endfunction()
365365

366-
function(_add_variant_link_flags)
366+
function(_add_host_variant_link_flags)
367367
set(oneValueArgs SDK ARCH BUILD_TYPE ENABLE_ASSERTIONS ANALYZE_CODE_COVERAGE
368368
DEPLOYMENT_VERSION_OSX DEPLOYMENT_VERSION_MACCATALYST DEPLOYMENT_VERSION_IOS DEPLOYMENT_VERSION_TVOS DEPLOYMENT_VERSION_WATCHOS
369369
RESULT_VAR_NAME ENABLE_LTO LTO_OBJECT_NAME LINK_LIBRARIES_VAR_NAME LIBRARY_SEARCH_DIRECTORIES_VAR_NAME
@@ -382,7 +382,7 @@ function(_add_variant_link_flags)
382382
set(link_libraries ${${LFLAGS_LINK_LIBRARIES_VAR_NAME}})
383383
set(library_search_directories ${${LFLAGS_LIBRARY_SEARCH_DIRECTORIES_VAR_NAME}})
384384

385-
_add_variant_c_compile_link_flags(
385+
_add_host_variant_c_compile_link_flags(
386386
SDK "${LFLAGS_SDK}"
387387
ARCH "${LFLAGS_ARCH}"
388388
BUILD_TYPE "${LFLAGS_BUILD_TYPE}"
@@ -670,7 +670,7 @@ function(_add_swift_host_library_single target)
670670
list(APPEND library_search_directories "$ENV{SDKROOT}/usr/lib/swift")
671671
endif()
672672

673-
_add_variant_c_compile_flags(
673+
_add_host_variant_c_compile_flags(
674674
SDK "${SWIFT_HOST_VARIANT_SDK}"
675675
ARCH "${SWIFT_HOST_VARIANT_ARCH}"
676676
BUILD_TYPE ${CMAKE_BUILD_TYPE}
@@ -685,7 +685,7 @@ function(_add_swift_host_library_single target)
685685
list(APPEND c_compile_flags -D_WINDLL)
686686
endif()
687687
endif()
688-
_add_variant_link_flags(
688+
_add_host_variant_link_flags(
689689
SDK "${SWIFT_HOST_VARIANT_SDK}"
690690
ARCH "${SWIFT_HOST_VARIANT_ARCH}"
691691
BUILD_TYPE ${CMAKE_BUILD_TYPE}
@@ -867,15 +867,15 @@ function(_add_swift_host_executable_single name)
867867
"${SWIFTLIB_DIR}/${SWIFT_SDK_${SWIFTEXE_SINGLE_SDK}_LIB_SUBDIR}")
868868

869869
# Add variant-specific flags.
870-
_add_variant_c_compile_flags(
870+
_add_host_variant_c_compile_flags(
871871
SDK "${SWIFTEXE_SINGLE_SDK}"
872872
ARCH "${SWIFTEXE_SINGLE_ARCHITECTURE}"
873873
BUILD_TYPE "${CMAKE_BUILD_TYPE}"
874874
ENABLE_ASSERTIONS "${LLVM_ENABLE_ASSERTIONS}"
875875
ENABLE_LTO "${SWIFT_TOOLS_ENABLE_LTO}"
876876
ANALYZE_CODE_COVERAGE "${SWIFT_ANALYZE_CODE_COVERAGE}"
877877
RESULT_VAR_NAME c_compile_flags)
878-
_add_variant_link_flags(
878+
_add_host_variant_link_flags(
879879
SDK "${SWIFTEXE_SINGLE_SDK}"
880880
ARCH "${SWIFTEXE_SINGLE_ARCHITECTURE}"
881881
BUILD_TYPE "${CMAKE_BUILD_TYPE}"

0 commit comments

Comments
 (0)