enforce expectations with an assert in deferExecutorBreadcrumb

kavon · kavon · commit 89233914a3b8 · 2022-05-03T16:51:51.000-07:00
I do not expect anyone to defer multiple breadcrumbs in a single
result plan.
diff --git a/lib/SILGen/ResultPlan.cpp b/lib/SILGen/ResultPlan.cpp
@@ -598,8 +598,9 @@ class ForeignAsyncInitializationPlan final : public ResultPlan {
     return ManagedValue::forUnmanaged(block);
   }
 
-  void deferExecutorBreadcrumb(ExecutorBreadcrumb &&breadcrumb) override {
-    this->breadcrumb = breadcrumb;
+  void deferExecutorBreadcrumb(ExecutorBreadcrumb &&crumb) override {
+    assert(!breadcrumb.needsEmit() && "overwriting an existing breadcrumb?");
+    breadcrumb = std::move(crumb);
   }
 
   RValue finish(SILGenFunction &SGF, SILLocation loc, CanType substType,

Original file line number	Diff line number	Diff line change
`@@ -598,8 +598,9 @@ class ForeignAsyncInitializationPlan final : public ResultPlan {`
`598`	`598`	`return ManagedValue::forUnmanaged(block);`
`599`	`599`	`}`
`600`	`600`
`601`		`- void deferExecutorBreadcrumb(ExecutorBreadcrumb &&breadcrumb) override {`
`602`		`- this->breadcrumb = breadcrumb;`
	`601`	`+ void deferExecutorBreadcrumb(ExecutorBreadcrumb &&crumb) override {`
	`602`	`+ assert(!breadcrumb.needsEmit() && "overwriting an existing breadcrumb?");`
	`603`	`+ breadcrumb = std::move(crumb);`
`603`	`604`	`}`
`604`	`605`
`605`	`606`	`RValue finish(SILGenFunction &SGF, SILLocation loc, CanType substType,`