[CSStep] Remove extraneous ) printing after PotentialBindings/Disjunctions.

Amritpan Kaur · Amritpan Kaur · commit 89623299a547 · 2022-08-25T15:09:29.000-07:00
Moved `debugLogger` into each if-block so it's indentation doesn't affect next `isDebugMode`.
diff --git a/lib/Sema/CSStep.cpp b/lib/Sema/CSStep.cpp
@@ -358,15 +358,11 @@ StepResult ComponentStep::take(bool prevFailed) {
   auto *disjunction = CS.selectDisjunction();
 
   if (CS.isDebugMode()) {
-    PrintOptions PO;
-    PO.PrintTypesForDebugging = true;
-
-    auto &log = getDebugLogger();
     if (!potentialBindings.empty()) {
+      auto &log = getDebugLogger();
       log << "(Potential Binding(s): " << '\n';
       log << potentialBindings;
     }
-    log.indent(CS.solverState->getCurrentIndent());
 
     SmallVector<Constraint *, 4> disjunctions;
     CS.collectDisjunctions(disjunctions);
@@ -392,7 +388,6 @@ StepResult ComponentStep::take(bool prevFailed) {
         log << ")\n";
       }
     }
-    log << ")\n";
   }
 
   if (CS.shouldAttemptFixes()) {

Original file line number	Diff line number	Diff line change
`@@ -358,15 +358,11 @@ StepResult ComponentStep::take(bool prevFailed) {`
`358`	`358`	`auto *disjunction = CS.selectDisjunction();`
`359`	`359`
`360`	`360`	`if (CS.isDebugMode()) {`
`361`		`- PrintOptions PO;`
`362`		`- PO.PrintTypesForDebugging = true;`
`363`		`-`
`364`		`- auto &log = getDebugLogger();`
`365`	`361`	`if (!potentialBindings.empty()) {`
	`362`	`+ auto &log = getDebugLogger();`
`366`	`363`	`log << "(Potential Binding(s): " << '\n';`
`367`	`364`	`log << potentialBindings;`
`368`	`365`	`}`
`369`		`- log.indent(CS.solverState->getCurrentIndent());`
`370`	`366`
`371`	`367`	`SmallVector<Constraint *, 4> disjunctions;`
`372`	`368`	`CS.collectDisjunctions(disjunctions);`
`@@ -392,7 +388,6 @@ StepResult ComponentStep::take(bool prevFailed) {`
`392`	`388`	`log << ")\n";`
`393`	`389`	`}`
`394`	`390`	`}`
`395`		`- log << ")\n";`
`396`	`391`	`}`
`397`	`392`
`398`	`393`	`if (CS.shouldAttemptFixes()) {`