Skip to content

Commit 8988fa9

Browse files
author
David Ungar
committed
Added fixmes
1 parent 3e95844 commit 8988fa9

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

include/swift/AST/ASTScope.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,11 @@ class ASTScopeImpl {
210210
/// node.
211211
void widenSourceRangeForIgnoredASTNode(ASTNode);
212212

213-
// InterpolatedStringLiteralExprs and EditorPlaceHolders respond to
214-
// getSourceRange with the starting point. But we might be asked to lookup an
215-
// identifer within one of them. So, find the real source range of them here.
213+
/// InterpolatedStringLiteralExprs and EditorPlaceHolders respond to
214+
/// getSourceRange with the starting point. But we might be asked to lookup an
215+
/// identifer within one of them. So, find the real source range of them here.
216+
///
217+
/// FIXME: Alter how these are parsed so getSourceRange is enough.
216218
SourceRange getEffectiveSourceRange(ASTNode) const;
217219

218220
public:

lib/AST/ASTScopeSourceRange.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,8 @@ class EffectiveEndFinder : public ASTWalker {
460460
};
461461
} // namespace
462462

463+
// FIXME: Alter how EditorPlaceHolder and InterpolgatedStringLiteralExpr are
464+
// parsed so getSourceRange is enough.
463465
SourceRange ASTScopeImpl::getEffectiveSourceRange(const ASTNode n) const {
464466
if (const auto *d = n.dyn_cast<Decl *>())
465467
return d->getSourceRange();

0 commit comments

Comments
 (0)