Exhaustive access marker verification.

Author: atrick

include/swift/SIL/InstructionUtils.h

@@ -139,6 +139,13 @@ struct LLVM_LIBRARY_VISIBILITY FindClosureResult {
 /// by a reabstraction thunk.
 FindClosureResult findClosureForAppliedArg(SILValue V);
 
+/// Visit each address accessed by the given memory operation.
+///
+/// This only visits instructions that modify memory in some user-visible way,
+/// which could be considered part of a formal access.
+void visitAccessedAddress(SILInstruction *I,
+                          std::function<void(Operand *)> visitor);
+
 /// A utility class for evaluating whether a newly parsed or deserialized
 /// function has qualified or unqualified ownership.
 ///

include/swift/SIL/SILInstruction.h

@@ -3408,17 +3408,17 @@ class AssignInst
                              NonValueInstruction> {
   friend SILBuilder;
 
+  FixedOperandList<2> Operands;
+
+  AssignInst(SILDebugLocation DebugLoc, SILValue Src, SILValue Dest);
+
+public:
   enum {
     /// the value being stored
     Src,
     /// the lvalue being stored to
     Dest
   };
-  FixedOperandList<2> Operands;
-
-  AssignInst(SILDebugLocation DebugLoc, SILValue Src, SILValue Dest);
-
-public:
 
   SILValue getSrc() const { return Operands[Src].get(); }
   SILValue getDest() const { return Operands[Dest].get(); }
@@ -3830,8 +3830,6 @@ class BindMemoryInst final :
                                           BindMemoryInst, NonValueInstruction> {
   friend SILBuilder;
 
-  enum { BaseOperIdx, IndexOperIdx, NumFixedOpers };
-
   SILType BoundType;
 
   static BindMemoryInst *create(
@@ -3845,6 +3843,8 @@ class BindMemoryInst final :
                                           Loc), BoundType(BoundType) {}
 
 public:
+  enum { BaseOperIdx, IndexOperIdx, NumFixedOpers };
+
   SILValue getBase() const { return getAllOperands()[BaseOperIdx].get(); }
 
   SILValue getIndex() const { return getAllOperands()[IndexOperIdx].get(); }
@@ -7303,12 +7303,6 @@ class CheckedCastAddrBranchInst
 
   CastConsumptionKind ConsumptionKind;
 
-  enum {
-    /// the value being stored
-    Src,
-    /// the lvalue being stored to
-    Dest
-  };
   FixedOperandList<2> Operands;
   SILSuccessor DestBBs[2];
 
@@ -7327,6 +7321,13 @@ class CheckedCastAddrBranchInst
         SourceType(srcType), TargetType(targetType) {}
 
 public:
+  enum {
+    /// the value being stored
+    Src,
+    /// the lvalue being stored to
+    Dest
+  };
+
   CastConsumptionKind getConsumptionKind() const { return ConsumptionKind; }
 
   SILValue getSrc() const { return Operands[Src].get(); }