Merge pull request #24346 from DougGregor/property-delegates-static

[Property delegates] Sure synthesized PatternBindingDecl static when needed

Author: DougGregor

lib/Sema/CodeSynthesis.cpp

@@ -1493,6 +1493,7 @@ static VarDecl *synthesizePropertyDelegateStorageDelegateProperty(
       ctx, property->getCorrectStaticSpelling(), pbdPattern,
       /*init*/nullptr, dc, SourceLoc());
   addMemberToContextIfNeeded(pbd, dc, var);
+  pbd->setStatic(var->isStatic());
 
   // Determine the access level for the property.
   AccessLevel access =
@@ -1575,6 +1576,7 @@ PropertyDelegateBackingPropertyInfoRequest::evaluate(Evaluator &evaluator,
       ctx, backingVar->getCorrectStaticSpelling(), pbdPattern,
       /*init*/nullptr, dc, SourceLoc());
   addMemberToContextIfNeeded(pbd, dc, var);
+  pbd->setStatic(var->isStatic());
 
   // Take the initializer from the original property.
   auto parentPBD = var->getParentPatternBinding();

test/SILGen/property_delegates.swift

@@ -40,6 +40,8 @@ func forceHasMemberwiseInit() {
   _ = HasMemberwiseInit<Int>()
 }
 
+  // CHECK: sil_global hidden @$s18property_delegates9UseStaticV13$staticWibbleAA4LazyOySaySiGGvpZ : $Lazy<Array<Int>>
+
 // HasMemberwiseInit.x.setter
 // CHECK-LABEL: sil hidden [transparent] [ossa] @$s18property_delegates17HasMemberwiseInitV1xSbvs : $@convention(method) <T where T : DefaultInit> (Bool, @inout HasMemberwiseInit<T>) -> () {
 // CHECK: bb0(%0 : $Bool, %1 : $*HasMemberwiseInit<T>):
@@ -250,3 +252,10 @@ func triggerUseLazy() {
   _ = UseLazy(bar: 17)
   _ = UseLazy<Int>(wibble: [1, 2, 3])
 }
+
+struct UseStatic {
+  // CHECK: sil hidden [transparent] [ossa] @$s18property_delegates9UseStaticV12staticWibbleSaySiGvgZ
+  // CHECK: sil hidden [global_init] [ossa] @$s18property_delegates9UseStaticV13$staticWibbleAA4LazyOySaySiGGvau
+  // CHECK: sil hidden [transparent] [ossa] @$s18property_delegates9UseStaticV12staticWibbleSaySiGvsZ
+  @Lazy static var staticWibble = [1, 2, 3]
+}