[ASTGen] Relax assertion on BridgedSourceLoc initializer

ahoppen · ahoppen · commit 8dec9addfcee · 2023-09-26T15:46:54.000-07:00
We do allow `SourceLoc` to point to the address right after the buffer ends to point to the end of a file.
diff --git a/lib/ASTGen/Sources/ASTGen/Bridge.swift b/lib/ASTGen/Sources/ASTGen/Bridge.swift
@@ -20,7 +20,7 @@ extension BridgedSourceLoc {
     at position: AbsolutePosition,
     in buffer: UnsafeBufferPointer<UInt8>
   ) {
-    precondition(position.utf8Offset >= 0 && position.utf8Offset < buffer.count)
+    precondition(position.utf8Offset >= 0 && position.utf8Offset <= buffer.count)
     self = SourceLoc_advanced(BridgedSourceLoc(raw: buffer.baseAddress!), SwiftInt(position.utf8Offset))
   }
 }
diff --git a/test/SourceKit/CursorInfo/at_eof_in_macro.swift b/test/SourceKit/CursorInfo/at_eof_in_macro.swift
@@ -0,0 +1,3 @@
+// RUN: %sourcekitd-test -req=cursor -pos=3:37 %s -- %s
+@freestanding(expression)
+macro powerAssert() = #externalMacro

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ extension BridgedSourceLoc {`
`20`	`20`	`at position: AbsolutePosition,`
`21`	`21`	`in buffer: UnsafeBufferPointer<UInt8>`
`22`	`22`	`) {`
`23`		`- precondition(position.utf8Offset >= 0 && position.utf8Offset < buffer.count)`
	`23`	`+ precondition(position.utf8Offset >= 0 && position.utf8Offset <= buffer.count)`
`24`	`24`	`self = SourceLoc_advanced(BridgedSourceLoc(raw: buffer.baseAddress!), SwiftInt(position.utf8Offset))`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+// RUN: %sourcekitd-test -req=cursor -pos=3:37 %s -- %s`
	`2`	`+@freestanding(expression)`
	`3`	`+macro powerAssert() = #externalMacro`