Skip to content

Commit 8ecce4f

Browse files
authored
[TF] Simplify tensorflow_osx_base build preset. (#29947)
Previously, the `tensorflow_osx_base` preset duplicated all options from from the `buildbot_osx_package` preset. This was not ideal: `tensorflow_osx_base` was not robust against changes to `buildbot_osx_package` and broke when changes were not copied. Now, `tensorflow_osx_base` directly uses `buildbot_osx_package` as a mixin. Updating `update-checkout-config.json` was necessary to make `build-toolchain-tensorflow` pass. Resolves TF-941.
1 parent 534d72c commit 8ecce4f

File tree

2 files changed

+21
-76
lines changed

2 files changed

+21
-76
lines changed

utils/build-presets.ini

Lines changed: 10 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -2328,84 +2328,29 @@ no-assertions
23282328
[preset: mixin_codesigning]
23292329
darwin-toolchain-application-cert=lldb_codesign
23302330

2331-
# Note: `tensorflow_osx_base` does not mix in `buildbot_osx_package` because
2332-
# they enable ios/tvos/watchos by default. Instead, options are copied here
2333-
# individually.
2334-
# TODO(TF-941): Try to mixin `buildbot_osx_package` directly. This requires
2335-
# options like `skip-ios` to override `ios`.
23362331
[preset: tensorflow_osx_base]
2337-
mixin-preset=mixin_lightweight_assertions
2338-
2339-
### From: mixin_osx_package_base
2340-
lldb
2341-
llbuild
2342-
swiftpm
2343-
swiftsyntax
2344-
skstresstester
2345-
playgroundsupport
2346-
libcxx
2347-
indexstore-db
2348-
sourcekit-lsp
2349-
2350-
release-debuginfo
2351-
2352-
lldb-no-debugserver
2353-
lldb-use-system-debugserver
2354-
lldb-build-type=Release
2355-
verbose-build
2356-
build-ninja
2357-
build-swift-stdlib-unittest-extra
2358-
playgroundsupport-build-type=Release
2359-
2360-
install-swift
2361-
install-lldb
2362-
install-llbuild
2363-
install-swiftpm
2364-
install-swiftsyntax
2365-
install-skstresstester
2366-
install-swiftevolve
2367-
install-playgroundsupport
2368-
2369-
darwin-install-extract-symbols
2370-
# Path where toolchain will be installed.
2371-
install-destdir=%(install_destdir)s
2372-
# Path where debug symbols will be installed.
2373-
install-symroot=%(install_symroot)s
2374-
# Path where the compiler + runtime + standard libraries will be installed.
2375-
install-prefix=%(install_toolchain_dir)s/usr
2376-
# Execute lit tests from swift-integration-tests repository.
2377-
test-installable-package
2378-
# Force reconfiguration.
2379-
reconfigure
2380-
2381-
swift-install-components=compiler;clang-resource-dir-symlink;stdlib;sdk-overlay;parser-lib;toolchain-tools;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers
2382-
llvm-install-components=llvm-cov;llvm-profdata;IndexStore;clang;clang-resource-headers;compiler-rt;clangd;dsymutil
2383-
install-libcxx
2384-
2385-
# Path to the .tar.gz package.
2386-
installable-package=%(installable_package)s
2387-
# Path to the .tar.gz symbols package.
2388-
symbols-package=%(symbols_package)s
2389-
# Info.plist
2390-
darwin-toolchain-bundle-identifier=%(darwin_toolchain_bundle_identifier)s
2391-
darwin-toolchain-display-name=%(darwin_toolchain_display_name)s
2392-
darwin-toolchain-display-name-short=%(darwin_toolchain_display_name_short)s
2393-
darwin-toolchain-name=%(darwin_toolchain_xctoolchain_name)s
2394-
darwin-toolchain-version=%(darwin_toolchain_version)s
2395-
darwin-toolchain-alias=%(darwin_toolchain_alias)s
2332+
mixin-preset=buildbot_osx_package
23962333

2397-
### TensorFlow custom options.
23982334
build-subdir=buildbot_osx
23992335
compiler-vendor=none
2336+
2337+
# Skip SwiftSyntax verification.
2338+
# TODO: Remove this when `utils/gyb_syntax_support` has no diff with master.
2339+
swiftsyntax-verify-generated-files=0
2340+
24002341
# Skip benchmarks.
24012342
skip-build-benchmarks
2343+
24022344
# Target only macOS.
2345+
# Note: these `skip-{i,tv,watch}os` flags override `{i,tv,watch}os` flags from
2346+
# the `buildbot_osx_package` preset.
24032347
skip-ios
24042348
skip-tvos
24052349
skip-watchos
24062350
stdlib-deployment-targets=macosx-x86_64
24072351
swift-primary-variant-sdk=OSX
24082352
swift-primary-variant-arch=x86_64
2353+
24092354
# Enable TensorFlow support.
24102355
enable-tensorflow
24112356
install-tensorflow

utils/update_checkout/update-checkout-config.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -310,21 +310,21 @@
310310
"repos": {
311311
"llvm-project": "b3057cffb63ed229b4552d57264414b4419fdb47",
312312
"swift": "tensorflow",
313-
"cmark": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
314-
"llbuild": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
313+
"cmark": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
314+
"llbuild": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
315315
"swift-tools-support-core": "0.0.1",
316-
"swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
316+
"swiftpm": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
317317
"swift-syntax": "1e524b3edc47e8ff66890d914b8bcd024e061631",
318-
"swift-stress-tester": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
319-
"swift-corelibs-xctest": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
320-
"swift-corelibs-foundation": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
321-
"swift-corelibs-libdispatch": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
322-
"swift-integration-tests": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
323-
"swift-xcode-playground-support": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
318+
"swift-stress-tester": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
319+
"swift-corelibs-xctest": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
320+
"swift-corelibs-foundation": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
321+
"swift-corelibs-libdispatch": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
322+
"swift-integration-tests": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
323+
"swift-xcode-playground-support": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
324324
"ninja": "release",
325325
"icu": "release-65-1",
326-
"indexstore-db": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
327-
"sourcekit-lsp": "swift-DEVELOPMENT-SNAPSHOT-2020-01-31-a",
326+
"indexstore-db": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
327+
"sourcekit-lsp": "swift-DEVELOPMENT-SNAPSHOT-2020-02-12-a",
328328
"swift-format": "master",
329329
"tensorflow": "v2.1.0-rc1",
330330
"tensorflow-swift-apis": "9a47e3cb71c798938b127729853d5911315a1d6e",

0 commit comments

Comments
 (0)