Merge pull request #23959 from jrose-apple/i-specialize-in-a-very-specific-type-of-security

[test] Add additional implementation-only conformance test cases

Author: jrose-apple

test/Sema/implementation-only-import-in-decls.swift

@@ -175,39 +175,47 @@ extension ConditionalGenericStruct: NormalProto where T: NormalProto {
 }
 public func testConditionalGeneric(_: NormalProtoAssocHolder<ConditionalGenericStruct<NormalStruct>>) {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
 
-public protocol PublicInferredAssociatedType {
+public protocol PublicAssociatedTypeProto {
   associatedtype Assoc: NormalProto
   func takesAssoc(_: Assoc)
 }
-@usableFromInline protocol UFIInferredAssociatedType {
+@usableFromInline protocol UFIAssociatedTypeProto {
   associatedtype Assoc: NormalProto
   func takesAssoc(_: Assoc)
 }
-protocol InternalInferredAssociatedType {
+protocol InternalAssociatedTypeProto {
   associatedtype Assoc: NormalProto
   func takesAssoc(_: Assoc)
 }
 
 public struct PublicInferredAssociatedTypeImpl {
   public func takesAssoc(_: NormalStruct) {}
 }
-extension PublicInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension PublicInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension PublicInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
+extension PublicInferredAssociatedTypeImpl: PublicAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension PublicInferredAssociatedTypeImpl: UFIAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension PublicInferredAssociatedTypeImpl: InternalAssociatedTypeProto {} // okay
 
 @usableFromInline struct UFIInferredAssociatedTypeImpl {
   public func takesAssoc(_: NormalStruct) {}
 }
-extension UFIInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension UFIInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension UFIInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
+extension UFIInferredAssociatedTypeImpl: PublicAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension UFIInferredAssociatedTypeImpl: UFIAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension UFIInferredAssociatedTypeImpl: InternalAssociatedTypeProto {} // okay
 
 struct InternalInferredAssociatedTypeImpl {
   public func takesAssoc(_: NormalStruct) {}
 }
-extension InternalInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // okay
-extension InternalInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // okay
-extension InternalInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
+extension InternalInferredAssociatedTypeImpl: PublicAssociatedTypeProto {} // okay
+extension InternalInferredAssociatedTypeImpl: UFIAssociatedTypeProto {} // okay
+extension InternalInferredAssociatedTypeImpl: InternalAssociatedTypeProto {} // okay
+
+public struct PublicExplicitAssociatedTypeImpl {
+  public typealias Assoc = NormalStruct
+  public func takesAssoc(_: NormalStruct) {}
+}
+extension PublicExplicitAssociatedTypeImpl: PublicAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension PublicExplicitAssociatedTypeImpl: UFIAssociatedTypeProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+extension PublicExplicitAssociatedTypeImpl: InternalAssociatedTypeProto {} // okay
 
 
 public protocol BaseProtoWithNoRequirement {
@@ -243,7 +251,7 @@ public struct RequirementsHandleSpecializationsToo: SlightlyMoreComplicatedRequi
   public func takesAssoc(_: [ConditionalGenericStruct<NormalStruct>]) {}
 }
 
-public struct ClassConstrainedGenericArg<T: NormalClass>: PublicInferredAssociatedType { // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'T'); 'BADLibrary' has been imported as '@_implementationOnly'}}
+public struct ClassConstrainedGenericArg<T: NormalClass>: PublicAssociatedTypeProto { // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'T'); 'BADLibrary' has been imported as '@_implementationOnly'}}
   public func takesAssoc(_: T) {}
 }
 

test/Sema/implementation-only-import-inlinable-conformances.swift

@@ -162,102 +162,9 @@ public func testDefaultArgument(_: Int = NormalProtoAssoc<NormalStruct>()) {} //
 
 public class SubclassOfNormalClass: NormalClass {}
 
-public func testInheritedConformance(_: NormalProtoAssocHolder<SubclassOfNormalClass>) {} // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-public func testSpecializedConformance(_: NormalProtoAssocHolder<GenericStruct<Int>>) {} // expected-error {{cannot use conformance of 'GenericStruct<T>' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-
-extension Array where Element == NormalProtoAssocHolder<NormalStruct> { // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func testConstrainedExtensionUsingBadConformance() {}
-}
-
-public struct ConditionalGenericStruct<T> {}
-extension ConditionalGenericStruct: NormalProto where T: NormalProto {
-  public typealias Assoc = Int
-}
-public func testConditionalGeneric(_: NormalProtoAssocHolder<ConditionalGenericStruct<NormalStruct>>) {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-
-public protocol PublicInferredAssociatedType {
-  associatedtype Assoc: NormalProto
-  func takesAssoc(_: Assoc)
-}
-@usableFromInline protocol UFIInferredAssociatedType {
-  associatedtype Assoc: NormalProto
-  func takesAssoc(_: Assoc)
-}
-protocol InternalInferredAssociatedType {
-  associatedtype Assoc: NormalProto
-  func takesAssoc(_: Assoc)
-}
-
-public struct PublicInferredAssociatedTypeImpl {
-  public func takesAssoc(_: NormalStruct) {}
-}
-extension PublicInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension PublicInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension PublicInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
-
-@usableFromInline struct UFIInferredAssociatedTypeImpl {
-  public func takesAssoc(_: NormalStruct) {}
-}
-extension UFIInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension UFIInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-extension UFIInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
-
-struct InternalInferredAssociatedTypeImpl {
-  public func takesAssoc(_: NormalStruct) {}
-}
-extension InternalInferredAssociatedTypeImpl: PublicInferredAssociatedType {} // okay
-extension InternalInferredAssociatedTypeImpl: UFIInferredAssociatedType {} // okay
-extension InternalInferredAssociatedTypeImpl: InternalInferredAssociatedType {} // okay
-
-
-public protocol BaseProtoWithNoRequirement {
-  associatedtype Assoc
-  func takesAssoc(_: Assoc)
-}
-public protocol RefinedProto: BaseProtoWithNoRequirement where Assoc: NormalProto {
-}
-
-public struct RefinedProtoImpl: RefinedProto { // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func takesAssoc(_: NormalStruct) {}
-}
-
-public protocol RefinedSelfProto where Self: NormalProto {}
-extension NormalStruct: RefinedSelfProto {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-
-public protocol RefinedSelfProtoInheritance: NormalProto {}
-extension NormalStruct: RefinedSelfProtoInheritance {} // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
-
-
-public protocol SlightlyMoreComplicatedRequirement {
-  associatedtype Assoc: Collection where Assoc.Element: NormalProto
-  func takesAssoc(_: Assoc)
-}
-public struct SlightlyMoreComplicatedRequirementImpl: SlightlyMoreComplicatedRequirement { // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc.Element' (inferred as 'NormalStruct'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func takesAssoc(_: [NormalStruct]) {}
-}
-public struct RequirementsHandleSubclassesToo: SlightlyMoreComplicatedRequirement { // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' in associated type 'Self.Assoc.Element' (inferred as 'SubclassOfNormalClass'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func takesAssoc(_: [SubclassOfNormalClass]) {}
-}
-
-public struct RequirementsHandleSpecializationsToo: SlightlyMoreComplicatedRequirement { // expected-error {{cannot use conformance of 'NormalStruct' to 'NormalProto' in associated type 'Self.Assoc.Element' (inferred as 'ConditionalGenericStruct<NormalStruct>'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func takesAssoc(_: [ConditionalGenericStruct<NormalStruct>]) {}
-}
-
-public struct ClassConstrainedGenericArg<T: NormalClass>: PublicInferredAssociatedType { // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' in associated type 'Self.Assoc' (inferred as 'T'); 'BADLibrary' has been imported as '@_implementationOnly'}}
-  public func takesAssoc(_: T) {}
+@inlinable public func testInheritedConformance() {
+  _ = NormalProtoAssocHolder<SubclassOfNormalClass>.self // expected-error {{cannot use conformance of 'NormalClass' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
 }
-
-
-public protocol RecursiveRequirements {
-  associatedtype Other: RecursiveRequirements
-}
-extension GenericStruct: RecursiveRequirements {
-  public typealias Other = GenericStruct<T>
-}
-public struct RecursiveRequirementsHolder<T: RecursiveRequirements> {}
-public func makeSureRecursiveRequirementsDontBreakEverything(_: RecursiveRequirementsHolder<GenericStruct<Int>>) {}
-
-
-@inlinable func testFunctionBody() {
-  
+@inlinable public func testSpecializedConformance() {
+  _ = NormalProtoAssocHolder<GenericStruct<Int>>.self // expected-error {{cannot use conformance of 'GenericStruct<T>' to 'NormalProto' here; 'BADLibrary' has been imported as '@_implementationOnly'}}
 }