[gardening] Remove an unnecessary bounds check on a container.

gottesmm · gottesmm · commit 90c0bf6e14b3 · 2021-04-14T20:04:28.000-07:00
As suggested by @atrick in review feedback in #36913.
diff --git a/include/swift/SILOptimizer/Utils/ScopeOptUtils.h b/include/swift/SILOptimizer/Utils/ScopeOptUtils.h
@@ -61,7 +61,6 @@ class AssertingScope {
   /// on Optional has value.
   void invalidateCleanup(unsigned cleanupIndex) {
     assert(!didPop && "Should not invalidate once popped?!");
-    assert(cleanupIndex < cleanups.size());
     assert(cleanups[cleanupIndex].hasValue());
     cleanups[cleanupIndex] = None;
   }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ class AssertingScope {`
`61`	`61`	`/// on Optional has value.`
`62`	`62`	`void invalidateCleanup(unsigned cleanupIndex) {`
`63`	`63`	`assert(!didPop && "Should not invalidate once popped?!");`
`64`		`- assert(cleanupIndex < cleanups.size());`
`65`	`64`	`assert(cleanups[cleanupIndex].hasValue());`
`66`	`65`	`cleanups[cleanupIndex] = None;`
`67`	`66`	`}`