Skip to content

Commit 91f4cbe

Browse files
committed
Merge pull request #2337 from austinzheng/az1
Fixing index(where:) API test
2 parents 0e641ce + e034946 commit 91f4cbe

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

stdlib/private/StdlibCollectionUnittest/CheckCollectionType.swift.gyb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,9 +833,9 @@ extension TestSuite {
833833

834834
self.test("\(testNamePrefix).index(where:)/semantics") {
835835
for test in findTests {
836-
let c = makeWrappedCollectionWithEquatableElement(test.sequence)
837836
let closureLifetimeTracker = LifetimeTracked(0)
838837
expectEqual(1, LifetimeTracked.instances)
838+
let c = makeWrappedCollectionWithEquatableElement(test.sequence)
839839
let result = c.index {
840840
(candidate) in
841841
_blackHole(closureLifetimeTracker)

validation-test/stdlib/Collection/LazyMapCollection.swift.gyb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,15 @@ CollectionTests.add${traversal}${kind}Tests(
4444
extractValue: { (element: LifetimeTracked) in
4545
OpaqueValue(element.value, identity: element.identity)
4646
},
47-
// FIXME: use LifetimeTracked once bug is validated/fixed
48-
make${kind}OfEquatable: { (elements: [MinimalEquatableValue]) -> LazyMap${traversal}${kind}<Minimal${traversal}${kind}<MinimalEquatableValue>, MinimalEquatableValue> in // -> LazyMap${traversal}${kind}<Minimal${traversal}${kind}<LifetimeTracked>, LifetimeTracked> in
47+
make${kind}OfEquatable: { (elements: [LifetimeTracked]) -> LazyMap${traversal}${kind}<Minimal${traversal}${kind}<LifetimeTracked>, LifetimeTracked> in
4948
Minimal${traversal}${kind}(elements: elements).lazy.map { $0 }
5049
},
51-
wrapValueIntoEquatable: identityEq, //{ (element: MinimalEquatableValue) in
52-
// LifetimeTracked(element.value, identity: element.identity)
53-
// },
54-
extractValueFromEquatable: identityEq //{ (element: LifetimeTracked) in
55-
// MinimalEquatableValue(element.value, identity: element.identity)
56-
// }
50+
wrapValueIntoEquatable: { (element: MinimalEquatableValue) in
51+
LifetimeTracked(element.value, identity: element.identity)
52+
},
53+
extractValueFromEquatable: { (element: LifetimeTracked) in
54+
MinimalEquatableValue(element.value, identity: element.identity)
55+
}
5756
)
5857
% end
5958

0 commit comments

Comments
 (0)