Skip to content

Commit 92fefdc

Browse files
authored
Merge pull request #24715 from gottesmm/pr-77235b46e32b8feb75c20ca06c668aeec1a36547
2 parents f966020 + da37a56 commit 92fefdc

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lib/SIL/SILVerifier.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,14 @@ struct ImmutableAddressUseVerifier {
512512
//
513513
// TODO: Can we do better?
514514
break;
515+
case SILInstructionKind::BranchInst:
516+
case SILInstructionKind::CondBranchInst:
517+
// We do not analyze through branches and cond_br instructions and just
518+
// assume correctness. This is so that we can avoid having to analyze
519+
// through phi loops and since we want to remove address phis (meaning
520+
// that this eventually would never be able to happen). Once that
521+
// changes happens, we should remove this code and just error below.
522+
break;
515523
case SILInstructionKind::ApplyInst:
516524
case SILInstructionKind::TryApplyInst:
517525
case SILInstructionKind::PartialApplyInst:

test/Prototypes/TextFormatting.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// RUN: %target-run-simple-swift | %FileCheck %s
22
// REQUIRES: executable_test
33

4-
// Temporary workaround; ImmutableAddressUseVerifier asserts nondeterministically. rdar://problem/50676315
5-
// REQUIRES: rdar50676315
6-
74
// Text Formatting Prototype
85
//
96
// This file demonstrates the concepts proposed in TextFormatting.rst

0 commit comments

Comments
 (0)