SpriteKit overlay: remove the subscript from SKNode

In iOS 8.0/OS X 10.10, SpriteKit introduced an
-objectForKeyedSubscript: method that enabled subscripting in
Objective-C. However, this subscript wasn't generally useful in Swift
because it took AnyObject and produced AnyObject, so the SpriteKit
overlay defined a subscript that took a String and produced an
[SKNode].

Subsequently, in iOS 9.0/OS X 10.10, -objectForKeyedSubscript: got
type annotations that gave it the appropriate Swift signature, which
made the subscript defined in the overlay redundant.

The twisty logic of the Clang importer would suppress the imported
subscript when it saw the one in the overlay, hiding the
redundancy. My cleanup of that logic in
0c0a0fa caused uses of the subscript
to be redundant.

Removal of the redundant code in the overlay is the overall best
answer, because it minimizes the size of the overlay and leaves the
API in the Objective-C header. However, this will introduce a
regression for SpriteKit applications targeting iOS 7.0/OS X 10.8,
where the overlay was compensating for the lack of this operation
before iOS 8.0 / OS X 10.8. There are workarounds here we can
investigate, although they're fairly hacky.

Author: DougGregor

stdlib/public/SDK/SpriteKit/SpriteKit.swift

@@ -15,18 +15,3 @@ public typealias SKColor = UIColor
   override init() { _sanityCheckFailure("don't touch me") }
   @objc func _copyImageData() -> NSData! { return nil }
 }
-
-extension SKNode {
-  public subscript (name: String) -> [SKNode] {
-    // Note: Don't stomp on objectForKeyedSubscript:
-    @objc(_swiftObjectForKeyedSubscript:) get {
-       var nodes = [SKNode]()
-       enumerateChildNodesWithName(name) { node, stop in
-         nodes.append(node)
-       }
-
-       return nodes
-    }
-  }
-}
-

test/1_stdlib/SpriteKit.swift

@@ -9,6 +9,15 @@
 import Foundation
 import SpriteKit
 
+// Check that the subscript is there.
+@available(OSX,introduced=10.10)
+@available(iOS,introduced=8.0)
+@available(tvOS,introduced=8.0)
+@available(watchOS,introduced=2.0)
+func testSubscript(node: SKNode) {
+  var nodes: [SKNode] = node["me"]
+}
+
 // SKColor is NSColor on OS X and UIColor on iOS.
 
 var r = CGFloat(0)