[stdlib] Make the rest of the shadow protocols internal

These shadow protocols don’t add any real type safety, and exposing them in the ABI seems unnecessary.

Author: lorentey

stdlib/public/SDK/Foundation/NSDictionary.swift

@@ -49,7 +49,7 @@ extension Dictionary {
     // The bug is fixed in: OS X 10.11.0, iOS 9.0, all versions of tvOS
     // and watchOS.
     self = Dictionary(
-      _immutableCocoaDictionary: _cocoaDictionary.copy(with: nil))
+      _immutableCocoaDictionary: _cocoaDictionary.copy(with: nil) as AnyObject)
   }
 }
 

stdlib/public/SDK/Foundation/NSSet.swift

@@ -29,7 +29,7 @@ extension Set {
     //
     // The bug is fixed in: OS X 10.11.0, iOS 9.0, all versions of tvOS
     // and watchOS.
-    self = Set(_immutableCocoaSet: _cocoaSet.copy(with: nil))
+    self = Set(_immutableCocoaSet: _cocoaSet.copy(with: nil) as AnyObject)
   }
 }
 

stdlib/public/core/ShadowProtocols.swift

@@ -24,11 +24,11 @@
 import SwiftShims
 
 @objc
-public protocol _ShadowProtocol {}
+internal protocol _ShadowProtocol {}
 
 /// A shadow for the `NSFastEnumeration` protocol.
 @objc
-public protocol _NSFastEnumeration : _ShadowProtocol {
+internal protocol _NSFastEnumeration: _ShadowProtocol {
   @objc(countByEnumeratingWithState:objects:count:)
   func countByEnumerating(
     with state: UnsafeMutablePointer<_SwiftNSFastEnumerationState>,
@@ -38,17 +38,17 @@ public protocol _NSFastEnumeration : _ShadowProtocol {
 
 /// A shadow for the `NSEnumerator` class.
 @objc
-public protocol _NSEnumerator : _ShadowProtocol {
+internal protocol _NSEnumerator: _ShadowProtocol {
   init()
   func nextObject() -> AnyObject?
 }
 
 /// A token that can be used for `NSZone*`.
-public typealias _SwiftNSZone = OpaquePointer
+internal typealias _SwiftNSZone = OpaquePointer
 
 /// A shadow for the `NSCopying` protocol.
 @objc
-public protocol _NSCopying : _ShadowProtocol {
+internal protocol _NSCopying: _ShadowProtocol {
   @objc(copyWithZone:)
   func copy(with zone: _SwiftNSZone?) -> AnyObject
 }

test/api-digester/Outputs/stability-stdlib-abi.swift.expected

@@ -344,3 +344,39 @@ Func _BridgeStorage.isUniquelyReferencedNative() has generic signature change fr
 Func _BridgeStorage.isUniquelyReferencedUnflaggedNative() has generic signature change from <τ_0_0, τ_0_1 where τ_0_0 : AnyObject, τ_0_1 : AnyObject> to <τ_0_0 where τ_0_0 : AnyObject>
 Struct _BridgeStorage has generic signature change from <τ_0_0, τ_0_1 where τ_0_0 : AnyObject, τ_0_1 : AnyObject> to <τ_0_0 where τ_0_0 : AnyObject>
 Var _BridgeStorage.objCInstance has declared type change from τ_0_1 to AnyObject
+
+Class _ContiguousArrayStorage has removed conformance to _NSCopying
+Class _ContiguousArrayStorage has removed conformance to _NSFastEnumeration
+Class _ContiguousArrayStorage has removed conformance to _ShadowProtocol
+Class _DictionaryStorage has removed conformance to _NSCopying
+Class _DictionaryStorage has removed conformance to _NSFastEnumeration
+Class _DictionaryStorage has removed conformance to _ShadowProtocol
+Class _EmptyDictionarySingleton has removed conformance to _NSCopying
+Class _EmptyDictionarySingleton has removed conformance to _NSFastEnumeration
+Class _EmptyDictionarySingleton has removed conformance to _ShadowProtocol
+Class _EmptySetSingleton has removed conformance to _NSCopying
+Class _EmptySetSingleton has removed conformance to _NSFastEnumeration
+Class _EmptySetSingleton has removed conformance to _ShadowProtocol
+Class _SetStorage has removed conformance to _NSCopying
+Class _SetStorage has removed conformance to _NSFastEnumeration
+Class _SetStorage has removed conformance to _ShadowProtocol
+Class _SharedStringStorage has removed conformance to _NSCopying
+Class _SharedStringStorage has removed conformance to _ShadowProtocol
+Class _StringStorage has removed conformance to _NSCopying
+Class _StringStorage has removed conformance to _ShadowProtocol
+Class __ContiguousArrayStorageBase has removed conformance to _NSCopying
+Class __ContiguousArrayStorageBase has removed conformance to _NSFastEnumeration
+Class __ContiguousArrayStorageBase has removed conformance to _ShadowProtocol
+Class __EmptyArrayStorage has removed conformance to _NSCopying
+Class __EmptyArrayStorage has removed conformance to _NSFastEnumeration
+Class __EmptyArrayStorage has removed conformance to _ShadowProtocol
+Class __SwiftDeferredNSArray has removed conformance to _NSCopying
+Class __SwiftDeferredNSArray has removed conformance to _NSFastEnumeration
+Class __SwiftDeferredNSArray has removed conformance to _ShadowProtocol
+Class __SwiftNativeNSArrayWithContiguousStorage has removed conformance to _NSCopying
+Class __SwiftNativeNSArrayWithContiguousStorage has removed conformance to _NSFastEnumeration
+Class __SwiftNativeNSArrayWithContiguousStorage has removed conformance to _ShadowProtocol
+Protocol _NSCopying has been removed
+Protocol _NSEnumerator has been removed
+Protocol _NSFastEnumeration has been removed
+Protocol _ShadowProtocol has been removed