Skip to content

Commit 95cff2a

Browse files
authored
Merge pull request #75569 from kubamracek/embedded-dont-build-in-standalone
[embedded] Don't build embedded stdlibs in 'standalone' builds
2 parents d736106 + c9513c7 commit 95cff2a

File tree

5 files changed

+17
-0
lines changed

5 files changed

+17
-0
lines changed

utils/build-presets.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2596,6 +2596,7 @@ build-swift-tools=0
25962596
build-swift-libexec=0
25972597
skip-early-swift-driver
25982598
skip-early-swiftsyntax
2599+
build-embedded-stdlib=0
25992600

26002601
# Then set the paths to our native tools. If compiling against a toolchain,
26012602
# these should all be the ./usr/bin directory.

utils/build_swift/build_swift/driver_arguments.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,10 @@ def create_argument_parser():
11371137
option('--build-swift-stdlib-static-print', toggle_true,
11381138
help='Build constant-folding print() support')
11391139

1140+
option('--build-embedded-stdlib', toggle_true,
1141+
default=True,
1142+
help='Build embedded stdlib')
1143+
11401144
option('--build-embedded-stdlib-cross-compiling', toggle_true,
11411145
help='Build embedded stdlib for cross-compiling targets.')
11421146

utils/build_swift/tests/expected_options.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
'build_swift_stdlib_unittest_extra': False,
8989
'build_swift_stdlib_static_print': False,
9090
'build_swift_stdlib_unicode_data': True,
91+
'build_embedded_stdlib': True,
9192
'build_embedded_stdlib_cross_compiling': False,
9293
'build_swift_clang_overlays': True,
9394
'build_swift_remote_mirror': True,
@@ -597,6 +598,7 @@ class BuildScriptImplOption(_BaseOption):
597598
EnableOption('--build-toolchain-only'),
598599
EnableOption('--build-swift-private-stdlib'),
599600
EnableOption('--build-swift-stdlib-unicode-data'),
601+
EnableOption('--build-embedded-stdlib'),
600602
EnableOption('--build-embedded-stdlib-cross-compiling'),
601603
EnableOption('--build-swift-libexec'),
602604
EnableOption('--build-swift-clang-overlays'),

utils/swift_build_support/swift_build_support/products/swift.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ def __init__(self, args, toolchain, source_dir, build_dir):
8585

8686
self.cmake_options.extend(self._enable_stdlib_unicode_data)
8787

88+
self.cmake_options.extend(self._enable_embedded_stdlib)
89+
8890
self.cmake_options.extend(self._enable_embedded_stdlib_cross_compiling)
8991

9092
self.cmake_options.extend(
@@ -259,6 +261,11 @@ def _enable_experimental_parser_validation(self):
259261
return [('SWIFT_ENABLE_EXPERIMENTAL_PARSER_VALIDATION:BOOL',
260262
self.args.enable_experimental_parser_validation)]
261263

264+
@property
265+
def _enable_embedded_stdlib(self):
266+
return [('SWIFT_SHOULD_BUILD_EMBEDDED_STDLIB',
267+
self.args.build_embedded_stdlib)]
268+
262269
@property
263270
def _enable_embedded_stdlib_cross_compiling(self):
264271
return [('SWIFT_SHOULD_BUILD_EMBEDDED_STDLIB_CROSS_COMPILING',

utils/swift_build_support/tests/products/test_swift.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def setUp(self):
6767
build_early_swiftsyntax=False,
6868
build_swift_stdlib_static_print=False,
6969
build_swift_stdlib_unicode_data=True,
70+
build_embedded_stdlib=True,
7071
build_embedded_stdlib_cross_compiling=False,
7172
swift_freestanding_is_darwin=False,
7273
build_swift_private_stdlib=True,
@@ -116,6 +117,7 @@ def test_by_default_no_cmake_options(self):
116117
'-DSWIFT_FREESTANDING_IS_DARWIN:BOOL=FALSE',
117118
'-DSWIFT_STDLIB_BUILD_PRIVATE:BOOL=TRUE',
118119
'-DSWIFT_STDLIB_ENABLE_UNICODE_DATA=TRUE',
120+
'-DSWIFT_SHOULD_BUILD_EMBEDDED_STDLIB=TRUE',
119121
'-DSWIFT_SHOULD_BUILD_EMBEDDED_STDLIB_CROSS_COMPILING=FALSE',
120122
'-DSWIFT_TOOLS_LD64_LTO_CODEGEN_ONLY_FOR_SUPPORTING_TARGETS:BOOL=FALSE',
121123
'-USWIFT_DEBUGINFO_NON_LTO_ARGS'
@@ -149,6 +151,7 @@ def test_swift_runtime_tsan(self):
149151
'-DSWIFT_FREESTANDING_IS_DARWIN:BOOL=FALSE',
150152
'-DSWIFT_STDLIB_BUILD_PRIVATE:BOOL=TRUE',
151153
'-DSWIFT_STDLIB_ENABLE_UNICODE_DATA=TRUE',
154+
'-DSWIFT_SHOULD_BUILD_EMBEDDED_STDLIB=TRUE',
152155
'-DSWIFT_SHOULD_BUILD_EMBEDDED_STDLIB_CROSS_COMPILING=FALSE',
153156
'-DSWIFT_TOOLS_LD64_LTO_CODEGEN_ONLY_FOR_SUPPORTING_TARGETS:BOOL=FALSE',
154157
'-USWIFT_DEBUGINFO_NON_LTO_ARGS'

0 commit comments

Comments
 (0)