[Distributed] Dont emit TBD also for distributed thunks (#80526)

* [Distributed] Accessor must be available cross module in resilient mode

This is an important fix for libraries using @resolvable in resilient
libraries. Without the fix we're missing an accessor and this will fail
some remote calls which make use of remote calls on resolvable
protocols. This would manifest as missing accessor error thrown by the
executeDistributedTarget function.

resolves rdar://148224780

* Disable test on windows since %env not supported

* [Distributed] Dont emit TBD also for distributed thunks

This resolves pedantic "all" TBD validation issues, i.e. we dont emit
unexpected records anymore - we would before as we only checked for
is_distributed but we also want to skip those for is_distributed_thunk

resolves rdar://128284016

Author: ktoso

lib/IRGen/GenMeta.cpp

@@ -1001,7 +1001,7 @@ namespace {
       // Emit the dispatch thunk.
       auto shouldEmitDispatchThunk =
           (Resilient || IGM.getOptions().WitnessMethodElimination) &&
-          !func.isDistributed();
+          (!func.isDistributed() || !func.isDistributedThunk());
       if (shouldEmitDispatchThunk) {
         IGM.emitDispatchThunk(func);
       }

test/Distributed/Runtime/distributed_actor_remoteCall_accessibleFunctions_crossModule.swift

@@ -9,6 +9,7 @@
 // RUN:     -module-name FakeDistributedActorSystems                           \
 // RUN:      %S/../Inputs/FakeDistributedActorSystems.swift                    \
 // RUN:     -enable-library-evolution                                          \
+// RUN:     -Xfrontend -validate-tbd-against-ir=all                            \
 // RUN:     -o %t/%target-library-name(FakeDistributedActorSystems)
 
 /// Build the Lib
@@ -23,6 +24,7 @@
 // RUN:     %t/src/ResilientAPILib.swift                                       \
 // RUN:     -lFakeDistributedActorSystems                                      \
 // RUN:     -enable-library-evolution                                          \
+// RUN:     -Xfrontend -validate-tbd-against-ir=all                            \
 // RUN:     -o %t/%target-library-name(ResilientAPILib)
 
 /// Build the ActorLib
@@ -37,6 +39,7 @@
 // RUN:     -lFakeDistributedActorSystems                                      \
 // RUN:     -lResilientAPILib                                                  \
 // RUN:     -enable-library-evolution                                          \
+// RUN:     -Xfrontend -validate-tbd-against-ir=all                            \
 // RUN:     -o %t/%target-library-name(ResilientImplLib)
 
 /// Build the client
@@ -51,6 +54,7 @@
 // RUN:     -L %t                                                              \
 // RUN:     %s                                                                 \
 // RUN:     -enable-library-evolution                                          \
+// RUN:     -Xfrontend -validate-tbd-against-ir=all                            \
 // RUN:     -o %t/a.out
 
 // Sign the main binary and all libraries

test/TBD/distributed_library_evolution.swift

@@ -9,6 +9,7 @@
 // RUN:     -enable-library-evolution                                          \
 // RUN:     -disable-availability-checking                                     \
 // RUN:     -emit-ir -o %t/test.ll -emit-tbd                                   \
+// RUN:     -validate-tbd-against-ir=all                                       \
 // RUN:     -emit-tbd-path %t/library.tbd -I %t -tbd-install_name protocol
 
 // RUN: %target-swift-frontend %t/library.swift                                \
@@ -18,9 +19,11 @@
 // RUN:     -package-name Package                                              \
 // RUN:     -module-name Library                                               \
 // RUN:     -emit-module-path %t/Library.swiftmodule                           \
+// RUN:     -validate-tbd-against-ir=all                                       \
 // RUN:     -emit-module-interface-path %t/Library.swiftinterface
 
-// RUN: %target-swift-frontend %t/actor.swift -enable-library-evolution \
+// RUN: %target-swift-frontend %t/actor.swift                               \
+// RUN:     -enable-library-evolution \
 // RUN:     -disable-availability-checking -emit-ir -o %t/test.ll -emit-tbd \
 // RUN:     -emit-tbd-path %t/actor.tbd -I %t -tbd-install_name actor
 
@@ -31,7 +34,8 @@
 // RUN:     -package-name Package                                          \
 // RUN:     -enable-library-evolution                                      \
 // RUN:     -module-name Client                                            \
-// RUN:     -emit-module-path %t/Client.swiftmodule                       \
+// RUN:     -emit-module-path %t/Client.swiftmodule                        \
+// RUN:     -validate-tbd-against-ir=all                                   \
 // RUN:     -emit-module-interface-path %t/Client.swiftinterface