Merge pull request #28280 from drodriguez/msvc-wants-you-to-move

drodriguez · web-flow · commit 9884e5019353 · 2019-11-14T20:01:11.000-08:00
[msvc] std::move the pointer for the method that requires an rvalue.
diff --git a/lib/Sema/TypeCheckDecl.cpp b/lib/Sema/TypeCheckDecl.cpp
@@ -2049,7 +2049,7 @@ DefaultArgumentInitContextRequest::evaluate(Evaluator &eval,
     if (param == otherParam)
       result = initDC;
     else
-      eval.cacheOutput(DefaultArgumentInitContextRequest{otherParam}, initDC);
+      eval.cacheOutput(DefaultArgumentInitContextRequest{otherParam}, std::move(initDC));
   }
   assert(result && "Didn't create init context?");
   return result;

Original file line number	Diff line number	Diff line change
`@@ -2049,7 +2049,7 @@ DefaultArgumentInitContextRequest::evaluate(Evaluator &eval,`
`2049`	`2049`	`if (param == otherParam)`
`2050`	`2050`	`result = initDC;`
`2051`	`2051`	`else`
`2052`		`- eval.cacheOutput(DefaultArgumentInitContextRequest{otherParam}, initDC);`
	`2052`	`+ eval.cacheOutput(DefaultArgumentInitContextRequest{otherParam}, std::move(initDC));`
`2053`	`2053`	`}`
`2054`	`2054`	`assert(result && "Didn't create init context?");`
`2055`	`2055`	`return result;`