Skip to content

Commit 98d6f22

Browse files
committed
[benchmark] run_smoke_bench -skip-check-added
Removed the option to `-check-added`, as it’s now run by default. Replaced with option to skip checking added benchmarks: `-skip-check-added`.
1 parent cbd8821 commit 98d6f22

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

benchmark/scripts/run_smoke_bench

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ def main():
6161
argparser.add_argument(
6262
'-skip-performance', action='store_true',
6363
help="Don't report performance differences")
64+
argparser.add_argument(
65+
'-skip-check-added', action='store_true',
66+
help="Don't validate newly added benchmarks")
6467
argparser.add_argument(
6568
'-o', type=str,
6669
help='In addition to stdout, write the results into a markdown file')
@@ -80,10 +83,6 @@ def main():
8083
argparser.add_argument(
8184
'newbuilddir', nargs=1, type=str,
8285
help='new benchmark build directory')
83-
argparser.add_argument(
84-
'-check-added', action='store_const',
85-
help="Run BenchmarkDoctor's check on newly added benchmarks",
86-
const=lambda args: check_added(args), dest='func')
8786
argparser.set_defaults(func=test_opt_levels)
8887
args = argparser.parse_args()
8988
VERBOSE = args.verbose
@@ -119,7 +118,8 @@ def test_opt_levels(args):
119118
args.platform, output_file):
120119
changes = True
121120

122-
check_added(args, output_file)
121+
if not args.skip_check_added:
122+
check_added(args, output_file)
123123

124124
if output_file:
125125
if changes:

0 commit comments

Comments
 (0)