Skip to content

Commit 9a04207

Browse files
committed
[benchmark] Doctor: emit mem_page details info
Promoting previously DEBUG message to INFO.
1 parent 783f034 commit 9a04207

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

benchmark/scripts/Benchmark_Driver

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,20 +407,25 @@ class BenchmarkDoctor(object):
407407
range_i1, range_i2 = max_i1 - min_i1, max_i2 - min_i2
408408
normal_range = 15 # pages
409409
name = measurements['name']
410+
more_info = False
410411

411412
if abs(min_i1 - min_i2) > max(range_i1, range_i2, normal_range):
413+
more_info = True
412414
BenchmarkDoctor.log_memory.error(
413415
"'%s' varies the memory footprint of the base "
414416
"workload depending on the `num-iters`.", name)
415417

416418
if max(range_i1, range_i2) > normal_range:
419+
more_info = True
417420
BenchmarkDoctor.log_memory.warning(
418421
"'%s' has very wide range of memory used between "
419422
"independent, repeated measurements.", name)
420423

421-
BenchmarkDoctor.log_memory.debug(
422-
"%s mem_pages [i1, i2]: min=[%d, %d] 𝚫=%d R=[%d, %d]", name,
423-
*[min_i1, min_i2, abs(min_i1 - min_i2), range_i1, range_i2])
424+
if more_info:
425+
BenchmarkDoctor.log_memory.info(
426+
"'%s' mem_pages [i1, i2]: min=[%d, %d] 𝚫=%d R=[%d, %d]",
427+
name,
428+
*[min_i1, min_i2, abs(min_i1 - min_i2), range_i1, range_i2])
424429

425430
@staticmethod
426431
def _adjusted_1s_samples(runtime):

benchmark/scripts/test_Benchmark_Driver.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -681,10 +681,18 @@ def test_benchmark_has_constant_memory_use(self):
681681
["'VariableMemory' varies the memory footprint of the base "
682682
"workload depending on the `num-iters`."],
683683
self.logs['error'])
684+
self.assert_contains(
685+
["'VariableMemory' "
686+
"mem_pages [i1, i2]: min=[1460, 1750] 𝚫=290 R=[12, 2]"],
687+
self.logs['info'])
684688
self.assert_contains(
685689
["'HighVariance' has very wide range of memory used between "
686690
"independent, repeated measurements."],
687691
self.logs['warning'])
692+
self.assert_contains(
693+
["'HighVariance' "
694+
"mem_pages [i1, i2]: min=[4818, 4674] 𝚫=144 R=[1382, 1570]"],
695+
self.logs['info'])
688696

689697

690698
if __name__ == '__main__':

0 commit comments

Comments
 (0)