Merge pull request #27219 from gottesmm/pr-76c8dc8ebfc577d7be7ce15c158337b575823c2a

Author: swift-ci

include/swift/SIL/OwnershipUtils.h

@@ -170,6 +170,18 @@ class LinearLifetimeChecker {
              ArrayRef<BranchPropagatedUser> nonConsumingUses,
              ownership::ErrorBehaviorKind errorBehavior,
              SmallVectorImpl<SILBasicBlock *> *leakingBlocks = nullptr);
+
+  /// Returns true that \p value forms a linear lifetime with consuming uses \p
+  /// consumingUses, non consuming uses \p nonConsumingUses. Returns false
+  /// otherwise.
+  bool validateLifetime(SILValue value,
+                        ArrayRef<BranchPropagatedUser> consumingUses,
+                        ArrayRef<BranchPropagatedUser> nonConsumingUses) {
+    return !checkValue(value, consumingUses, nonConsumingUses,
+                       ownership::ErrorBehaviorKind::ReturnFalse,
+                       nullptr /*leakingBlocks*/)
+                .getFoundError();
+  }
 };
 
 /// Returns true if v is an address or trivial.

lib/SIL/OwnershipUtils.cpp

@@ -207,7 +207,5 @@ bool BorrowScopeIntroducingValue::areInstructionsWithinScope(
       [&scratchSpace](SILInstruction *i) { scratchSpace.emplace_back(i); });
 
   LinearLifetimeChecker checker(visitedBlocks, deadEndBlocks);
-  auto result = checker.checkValue(value, scratchSpace, instructions,
-                                   ownership::ErrorBehaviorKind::ReturnFalse);
-  return !result.getFoundError();
+  return checker.validateLifetime(value, scratchSpace, instructions);
 }

lib/SILOptimizer/Mandatory/SemanticARCOpts.cpp

@@ -673,9 +673,10 @@ class StorageGuaranteesLoadVisitor
     SmallPtrSet<SILBasicBlock *, 4> visitedBlocks;
 
     LinearLifetimeChecker checker(visitedBlocks, ARCOpt.getDeadEndBlocks());
-    auto result = checker.checkValue(baseObject, baseEndBorrows, valueDestroys,
-                                     ownership::ErrorBehaviorKind::ReturnFalse);
-    return answer(result.getFoundError());
+    // Returns true on success. So we invert.
+    bool foundError =
+        !checker.validateLifetime(baseObject, baseEndBorrows, valueDestroys);
+    return answer(foundError);
   }
 
   // TODO: Handle other access kinds?