Skip to content

Commit 9b456df

Browse files
committed
Remove markers for tech review queries.
1 parent fbcf868 commit 9b456df

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

stdlib/public/Concurrency/TaskGroup.swift

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ public struct TaskGroup<ChildTaskResult> {
373373
///
374374
/// There are no restrictions on where you can call this method.
375375
/// Code inside a child task or even another task can cancel a group.
376-
/// ◊TR: Is this rewrite too strong?
377376
///
378377
/// - SeeAlso: `Task.isCancelled`
379378
/// - SeeAlso: `TaskGroup.isCancelled`
@@ -388,8 +387,6 @@ public struct TaskGroup<ChildTaskResult> {
388387
/// If the task that's currently running this group is canceled,
389388
/// the group is also implicitly canceled,
390389
/// which is also reflected in this property's value.
391-
/// ◊TR: Why do we have two implementations of this method?
392-
/// ◊TR: What's the difference between them?
393390
public var isCancelled: Bool {
394391
return _taskGroupIsCancelled(group: _group)
395392
}
@@ -669,7 +666,6 @@ public struct ThrowingTaskGroup<ChildTaskResult, Failure: Error> {
669666
///
670667
/// There are no restrictions on where you can call this method.
671668
/// Code inside a child task or even another task can cancel a group.
672-
/// ◊TR: Is this rewrite too strong?
673669
///
674670
/// - SeeAlso: `Task.isCancelled`
675671
/// - SeeAlso: `ThrowingTaskGroup.isCancelled`
@@ -684,8 +680,6 @@ public struct ThrowingTaskGroup<ChildTaskResult, Failure: Error> {
684680
/// If the task that's currently running this group is canceled,
685681
/// the group is also implicitly canceled,
686682
/// which is also reflected in this property's value.
687-
/// ◊TR: Why do we have two implementations of this method?
688-
/// ◊TR: What's the difference between them?
689683
public var isCancelled: Bool {
690684
return _taskGroupIsCancelled(group: _group)
691685
}

stdlib/public/Concurrency/TaskSleep.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import Swift
1616
extension Task where Success == Never, Failure == Never {
1717
/// Suspends the current task for at least the given duration
1818
/// in nanoseconds.
19-
/// ◊TR: Why do we have both sleep(_:) and sleep(nanoseconds:) -- what's the difference between them?
20-
/// ◊TR: It looks like only sleep(nanoseconds:) throws.
2119
///
2220
/// This function doesn't block the underlying thread.
2321
public static func sleep(_ duration: UInt64) async {

0 commit comments

Comments
 (0)