[CSBindings] Fix early return condition in TypeVariableBinding::attempt

xedin · xedin · commit 9b6ecf92ee6d · 2022-11-04T10:54:28.000-07:00
When `reportHole()` returns `true` it indicates a failure and
`attempt` has to return `false` right away.
diff --git a/lib/Sema/CSBindings.cpp b/lib/Sema/CSBindings.cpp
@@ -2208,8 +2208,9 @@ bool TypeVariableBinding::attempt(ConstraintSystem &cs) const {
   if (Binding.isDefaultableBinding()) {
     cs.DefaultedConstraints.insert(srcLocator);
 
+    // Fail if hole reporting fails.
     if (type->isPlaceholder() && reportHole())
-      return true;
+      return false;
   }
 
   if (cs.simplify())

Original file line number	Diff line number	Diff line change
`@@ -2208,8 +2208,9 @@ bool TypeVariableBinding::attempt(ConstraintSystem &cs) const {`
`2208`	`2208`	`if (Binding.isDefaultableBinding()) {`
`2209`	`2209`	`cs.DefaultedConstraints.insert(srcLocator);`
`2210`	`2210`
	`2211`	`+ // Fail if hole reporting fails.`
`2211`	`2212`	`if (type->isPlaceholder() && reportHole())`
`2212`		`- return true;`
	`2213`	`+ return false;`
`2213`	`2214`	`}`
`2214`	`2215`
`2215`	`2216`	`if (cs.simplify())`