Merge pull request #12965 from mattgallagher/patch-1

CodaFi · web-flow · commit 9bb4fc6f22c0 · 2019-11-12T11:22:06.000-08:00
Fixed faulty boolean logic
diff --git a/lib/Demangling/Demangler.cpp b/lib/Demangling/Demangler.cpp
@@ -2339,7 +2339,7 @@ std::string Demangler::demangleBridgedMethodParams() {
 
   while (!nextIf('_')) {
     auto c = nextChar();
-    if (!c && c != 'n' && c != 'b')
+    if (c != 'n' && c != 'b')
       return std::string();
     Str.push_back(c);
   }

Original file line number	Diff line number	Diff line change
`@@ -2339,7 +2339,7 @@ std::string Demangler::demangleBridgedMethodParams() {`
`2339`	`2339`
`2340`	`2340`	`while (!nextIf('_')) {`
`2341`	`2341`	`auto c = nextChar();`
`2342`		`- if (!c && c != 'n' && c != 'b')`
	`2342`	`+ if (c != 'n' && c != 'b')`
`2343`	`2343`	`return std::string();`
`2344`	`2344`	`Str.push_back(c);`
`2345`	`2345`	`}`