more workarounds for embedded

Author: ktoso

stdlib/public/Concurrency/TaskGroup+Embedded.swift

@@ -38,47 +38,46 @@ extension TaskGroup {
     let builtinSerialExecutor =
       Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
 
-    var task: Builtin.NativeObject? =
-      Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        taskGroup: _group,
-        operation: operation).0
-
-    // Assert that we did create the task, but there's no need to store it,
-    // as it was added to the group itself.
-    assert(task != nil, "Expected task to be created!")
+
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
   }
 
   @available(SwiftStdlib 5.1, *)
   @_alwaysEmitIntoClient
   public mutating func addTaskUnlessCancelled(
     priority: TaskPriority? = nil,
     operation: sending @escaping @isolated(any) () async -> ChildTaskResult
-  ) {
+  ) -> Bool {
+    let canAdd = _taskGroupAddPendingTask(group: _group, unconditionally: false)
+
+    guard canAdd else {
+      return false
+    }
+
     let flags = taskCreateFlags(
       priority: priority,
       isChildTask: true,
       copyTaskLocals: false,
       inheritContext: false,
       enqueueJob: true,
       addPendingGroupTaskUnconditionally: false,
-      isDiscardingTask: false
+      isDiscardingTask: true
     )
 
     let builtinSerialExecutor =
       Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
 
-    var task: Builtin.NativeObject? =
-      Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        taskGroup: _group,
-        operation: operation).0
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
 
-    // Assert that we did create the task, but there's no need to store it,
-    // as it was added to the group itself.
-    assert(task != nil, "Expected task to be created!")
+    return true
   }
 }
 
@@ -104,47 +103,174 @@ extension ThrowingTaskGroup {
     let builtinSerialExecutor =
       Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
 
-    var task: Builtin.NativeObject? =
-      Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        taskGroup: _group,
-        operation: operation).0
-
-    // Assert that we did create the task, but there's no need to store it,
-    // as it was added to the group itself.
-    assert(task != nil, "Expected task to be created!")
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
   }
 
   @available(SwiftStdlib 5.1, *)
   @_alwaysEmitIntoClient
   public mutating func addTaskUnlessCancelled(
     priority: TaskPriority? = nil,
     operation: sending @escaping @isolated(any) () async throws -> ChildTaskResult
+  ) -> Bool {
+    let canAdd = _taskGroupAddPendingTask(group: _group, unconditionally: false)
+
+    guard canAdd else {
+      return false
+    }
+
+    let flags = taskCreateFlags(
+      priority: priority,
+      isChildTask: true,
+      copyTaskLocals: false,
+      inheritContext: false,
+      enqueueJob: true,
+      addPendingGroupTaskUnconditionally: false,
+      isDiscardingTask: true
+    )
+
+    let builtinSerialExecutor =
+      Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
+
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
+
+    return true
+  }
+}
+
+@available(SwiftStdlib 5.9, *)
+extension DiscardingTaskGroup {
+
+  @available(SwiftStdlib 5.9, *)
+  @_alwaysEmitIntoClient
+  public mutating func addTask(
+    priority: TaskPriority? = nil,
+    operation: sending @escaping @isolated(any) () async -> Void
   ) {
+    let flags = taskCreateFlags(
+      priority: priority,
+      isChildTask: true,
+      copyTaskLocals: false,
+      inheritContext: false,
+      enqueueJob: true,
+      addPendingGroupTaskUnconditionally: true,
+      isDiscardingTask: true
+    )
+
+    let builtinSerialExecutor =
+      Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
+
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
+  }
+
+  @available(SwiftStdlib 5.9, *)
+  @_alwaysEmitIntoClient
+  public mutating func addTaskUnlessCancelled(
+    priority: TaskPriority? = nil,
+    operation: sending @escaping @isolated(any) () async -> Void
+  ) -> Bool {
+    let canAdd = _taskGroupAddPendingTask(group: _group, unconditionally: false)
+
+    guard canAdd else {
+      return false
+    }
+
     let flags = taskCreateFlags(
       priority: priority,
       isChildTask: true,
       copyTaskLocals: false,
       inheritContext: false,
       enqueueJob: true,
       addPendingGroupTaskUnconditionally: false,
-      isDiscardingTask: false
+      isDiscardingTask: true
+    )
+
+    let builtinSerialExecutor =
+      Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
+
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
+
+    return true
+  }
+}
+
+@available(SwiftStdlib 5.9, *)
+extension ThrowingDiscardingTaskGroup {
+
+  @available(SwiftStdlib 5.9, *)
+  @_alwaysEmitIntoClient
+  public mutating func addTask(
+    priority: TaskPriority? = nil,
+    operation: sending @escaping @isolated(any) () async throws -> Void
+  ) {
+    let flags = taskCreateFlags(
+      priority: priority,
+      isChildTask: true,
+      copyTaskLocals: false,
+      inheritContext: false,
+      enqueueJob: true,
+      addPendingGroupTaskUnconditionally: true,
+      isDiscardingTask: true
+    )
+
+    let builtinSerialExecutor =
+      Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
+
+
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
+  }
+
+  @available(SwiftStdlib 5.9, *)
+  @_alwaysEmitIntoClient
+  public mutating func addTaskUnlessCancelled(
+    priority: TaskPriority? = nil,
+    operation: sending @escaping @isolated(any) () async throws -> Void
+  ) -> Bool {
+    let canAdd = _taskGroupAddPendingTask(group: _group, unconditionally: false)
+
+    guard canAdd else {
+      return false
+    }
+
+    let flags = taskCreateFlags(
+      priority: priority,
+      isChildTask: true,
+      copyTaskLocals: false,
+      inheritContext: false,
+      enqueueJob: true,
+      addPendingGroupTaskUnconditionally: false,
+      isDiscardingTask: true
     )
 
     let builtinSerialExecutor =
       Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
 
-    var task: Builtin.NativeObject? =
-      Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        taskGroup: _group,
-        operation: operation).0
+    _ = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      taskGroup: _group,
+      operation: operation).0
 
-    // Assert that we did create the task, but there's no need to store it,
-    // as it was added to the group itself.
-    assert(task != nil, "Expected task to be created!")
+    return true
   }
 }