Update ConditionForwarding for @guaranteed forwarding phi support

Author: meg-gupta

lib/SILOptimizer/Transforms/ConditionForwarding.cpp

@@ -202,6 +202,14 @@ bool ConditionForwarding::tryOptimize(SwitchEnumInst *SEI) {
     if (!EI)
       return false;
 
+    if (getFunction()->hasOwnership() && EI->hasOperand()) {
+      auto some = EI->getOperand();
+      if (some->getOwnershipKind() == OwnershipKind::Guaranteed &&
+          isa<SILFunctionArgument>(some)) {
+        return false;
+      }
+    }
+
     if (CommonBranchBlock && PredPred != CommonBranchBlock)
       return false;
     CommonBranchBlock = PredPred;

test/SILOptimizer/conditionforwarding_nontrivial_ossa.sil

@@ -71,7 +71,8 @@ bb6:
   return %r : $()
 }
 
-// Currently, this is not optimized away because memory behavior of begin_borrow is conservative
+// Currently, this is not optimized away because enum has @guaranteed function argument, which 
+// will need a borrow scope before being forwarded
 // CHECK-LABEL: sil [ossa] @simple_forwarding2 :
 // CHECK: switch_enum
 // CHECK-LABEL: } // end sil function 'simple_forwarding2'
@@ -81,13 +82,11 @@ bb0(%0 : $Builtin.Int1, %1 : @guaranteed $Klass):
 
 bb1:
   %2 = enum $E, #E.A!enumelt, %1 : $Klass
-  %borrow2 = begin_borrow %2 : $E
-  br bb3(%borrow2 : $E)
+  br bb3(%2 : $E)
 
 bb2:
   %3 = enum $E, #E.B!enumelt, %1 : $Klass
-  %borrow3 = begin_borrow %3 : $E
-  br bb3(%borrow3 : $E)
+  br bb3(%3 : $E)
 
 bb3(%14 : @guaranteed $E):
   %15 = function_ref @callee : $@convention(thin) () -> ()
@@ -101,7 +100,6 @@ bb5(%18 : @guaranteed $Klass):
   br bb6
 
 bb6:
-  end_borrow %14 : $E
   %r = tuple ()
   return %r : $()
 }
@@ -187,22 +185,19 @@ bb6:
 
 // CHECK-LABEL: sil [ossa] @simple_switch_enum_forwarding2 : 
 // CHECK: switch_enum
-// CHECK: switch_enum
 // CHECK-LABEL: } // end sil function 'simple_switch_enum_forwarding2'
 sil [ossa] @simple_switch_enum_forwarding2 : $@convention(thin) (@guaranteed E3) -> () {
 bb0(%0 : @guaranteed $E3):
   switch_enum %0 : $E3, case #E3.A!enumelt: bb1, default bb2
 
 bb1(%1 : @guaranteed $Klass):
   %2 = enum $E, #E.A!enumelt, %1 : $Klass
-  %borrow2 = begin_borrow %2 : $E
-  br bb3(%borrow2 : $E)
+  br bb3(%2 : $E)
 
 bb2(%defaultenum : @guaranteed $E3):
   %defaultklass = unchecked_enum_data %defaultenum : $E3, #E3.B!enumelt
   %3 = enum $E, #E.B!enumelt, %defaultklass : $Klass
-  %borrow3 = begin_borrow %3 : $E
-  br bb3(%borrow3 : $E)
+  br bb3(%3 : $E)
 
 bb3(%14 : @guaranteed $E):
   %15 = function_ref @callee : $@convention(thin) () -> ()
@@ -216,7 +211,6 @@ bb5(%5 : @guaranteed $Klass):
   br bb6
 
 bb6:
-  end_borrow %14 : $E
   %r = tuple ()
   return %r : $()
 }