have suppressed entries checked early

In situations like building a generic
signature or simply visiting members like
a deinit, it's important that we've already
resolved the types in the SuppressedEntries
list of a TypeDecl, otherwise we may get
incorrect answers about whether the type
is suppressed or not.

Author: kavon

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -187,11 +187,6 @@ static void checkInheritanceClause(
   const ExtensionDecl *ext = nullptr;
   const TypeDecl *typeDecl = nullptr;
   const Decl *decl;
-
-  /// The suppressed implicit conformances are physically separate but part of
-  /// the same syntactic inheritance clause sequence.
-  checkSuppressedEntries(declUnion);
-
   if ((ext = declUnion.dyn_cast<const ExtensionDecl *>())) {
     decl = ext;
 
@@ -570,6 +565,7 @@ static void checkGenericParams(GenericContext *ownerCtx) {
 
   for (auto gp : *genericParams) {
     TypeChecker::checkDeclAttributes(gp);
+    assert(gp->getSuppressed().empty() && "unexpected suppressed conformances");
     checkInheritanceClause(gp);
   }
 
@@ -2544,6 +2540,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   void visitAssociatedTypeDecl(AssociatedTypeDecl *AT) {
     TypeChecker::checkDeclAttributes(AT);
 
+    assert(AT->getSuppressed().empty() && "unexpected suppressed conformances");
     checkInheritanceClause(AT);
     auto *proto = AT->getProtocol();
 
@@ -2625,6 +2622,9 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   void visitEnumDecl(EnumDecl *ED) {
     checkUnsupportedNestedType(ED);
 
+    // Establish suppressed conformances early to support queries elsewhere.
+    checkSuppressedEntries(ED);
+
     // FIXME: Remove this once we clean up the mess involving raw values.
     (void) ED->getInterfaceType();
 
@@ -2696,6 +2696,9 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   void visitStructDecl(StructDecl *SD) {
     checkUnsupportedNestedType(SD);
 
+    // Establish suppressed conformances early to support queries elsewhere.
+    checkSuppressedEntries(SD);
+
     checkGenericParams(SD);
 
     // Force lowering of stored properties.
@@ -2884,6 +2887,9 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   void visitClassDecl(ClassDecl *CD) {
     checkUnsupportedNestedType(CD);
 
+    // Establish suppressed conformances early to support queries elsewhere.
+    checkSuppressedEntries(CD);
+
     // Force creation of the generic signature.
     (void) CD->getGenericSignature();
 
@@ -3051,6 +3057,9 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   void visitProtocolDecl(ProtocolDecl *PD) {
     checkUnsupportedNestedType(PD);
 
+    // Establish suppressed conformances early to support queries elsewhere.
+    checkSuppressedEntries(PD);
+
     // Check for circular inheritance within the protocol.
     (void) PD->hasCircularInheritedProtocols();