[Frontend] Inline parseAndCheckTypesUpTo

`performSemaUpTo` will only shrink from here, so
go ahead and inline `parseAndCheckTypesUpTo` into
it already.

Author: hamishknight

include/swift/Frontend/Frontend.h

@@ -671,7 +671,6 @@ class CompilerInstance {
   ImplicitImportInfo getImplicitImportInfo() const;
 
   void performSemaUpTo(SourceFile::ASTStage_t LimitStage);
-  void parseAndCheckTypesUpTo(SourceFile::ASTStage_t LimitStage);
 
   /// Return true if had load error
   bool parsePartialModulesAndInputFiles();

lib/Frontend/Frontend.cpp

@@ -794,32 +794,6 @@ void CompilerInstance::performSemaUpTo(SourceFile::ASTStage_t LimitStage) {
                                         MainBufferID);
   }
 
-  parseAndCheckTypesUpTo(LimitStage);
-}
-
-bool CompilerInstance::loadStdlib() {
-  FrontendStatsTracer tracer(getStatsReporter(), "load-stdlib");
-  ModuleDecl *M = Context->getStdlibModule(true);
-
-  if (!M) {
-    Diagnostics.diagnose(SourceLoc(), diag::error_stdlib_not_found,
-                         Invocation.getTargetTriple());
-    return false;
-  }
-
-  // If we failed to load, we should have already diagnosed
-  if (M->failedToLoad()) {
-    assert(Diagnostics.hadAnyError() &&
-           "Module failed to load but nothing was diagnosed?");
-    return false;
-  }
-  return true;
-}
-
-void CompilerInstance::parseAndCheckTypesUpTo(
-    SourceFile::ASTStage_t limitStage) {
-  FrontendStatsTracer tracer(getStatsReporter(), "parse-and-check-types");
-
   bool hadLoadError = parsePartialModulesAndInputFiles();
   if (hadLoadError)
     return;
@@ -833,7 +807,7 @@ void CompilerInstance::parseAndCheckTypesUpTo(
   MainModule->setHasResolvedImports();
 
   forEachFileToTypeCheck([&](SourceFile &SF) {
-    if (limitStage == SourceFile::ImportsResolved) {
+    if (LimitStage == SourceFile::ImportsResolved) {
       bindExtensions(SF);
       return;
     }
@@ -849,13 +823,32 @@ void CompilerInstance::parseAndCheckTypesUpTo(
   });
 
   // If the limiting AST stage is import resolution, we're done.
-  if (limitStage <= SourceFile::ImportsResolved) {
+  if (LimitStage <= SourceFile::ImportsResolved) {
     return;
   }
 
   finishTypeChecking();
 }
 
+bool CompilerInstance::loadStdlib() {
+  FrontendStatsTracer tracer(getStatsReporter(), "load-stdlib");
+  ModuleDecl *M = Context->getStdlibModule(true);
+
+  if (!M) {
+    Diagnostics.diagnose(SourceLoc(), diag::error_stdlib_not_found,
+                         Invocation.getTargetTriple());
+    return false;
+  }
+
+  // If we failed to load, we should have already diagnosed
+  if (M->failedToLoad()) {
+    assert(Diagnostics.hadAnyError() &&
+           "Module failed to load but nothing was diagnosed?");
+    return false;
+  }
+  return true;
+}
+
 bool CompilerInstance::parsePartialModulesAndInputFiles() {
   FrontendStatsTracer tracer(getStatsReporter(),
                              "parse-partial-modules-and-input-files");