Merge pull request #34762 from aschwaighofer/irgen_var_sized_alloca_async

IRGen: Fix debug emission for dynamically sized stack vars

Author: aschwaighofer

lib/IRGen/IRGenSIL.cpp

@@ -4627,6 +4627,17 @@ void IRGenSILFunction::visitIsEscapingClosureInst(
   setLoweredExplosion(i, out);
 }
 
+static bool isCallToSwiftTaskAlloc(llvm::Value *val) {
+  auto *call = dyn_cast<llvm::CallInst>(val);
+  if (!call)
+    return false;
+  auto *callee = call->getCalledFunction();
+  if (!callee)
+    return false;
+  auto isTaskAlloc = callee->getName().equals("swift_task_alloc");
+  return isTaskAlloc;
+}
+
 void IRGenSILFunction::emitDebugInfoForAllocStack(AllocStackInst *i,
                                                   const TypeInfo &type,
                                                   llvm::Value *addr) {
@@ -4644,6 +4655,11 @@ void IRGenSILFunction::emitDebugInfoForAllocStack(AllocStackInst *i,
     else if (auto *CoroAllocaGet = dyn_cast<llvm::IntrinsicInst>(Op0)) {
       if (CoroAllocaGet->getIntrinsicID() == llvm::Intrinsic::coro_alloca_get)
         addr = CoroAllocaGet;
+    } else if (auto *call = dyn_cast<llvm::CallInst>(Op0)) {
+      addr = call;
+      bool isTaskAlloc = isCallToSwiftTaskAlloc(call);
+      assert(isTaskAlloc && "expecting call to swift_task_alloc");
+      (void)isTaskAlloc;
     }
   }
 
@@ -4659,7 +4675,7 @@ void IRGenSILFunction::emitDebugInfoForAllocStack(AllocStackInst *i,
 
   // At this point addr must be an alloca or an undef.
   assert(isa<llvm::AllocaInst>(addr) || isa<llvm::UndefValue>(addr) ||
-         isa<llvm::IntrinsicInst>(addr));
+         isa<llvm::IntrinsicInst>(addr) || isCallToSwiftTaskAlloc(addr));
 
   auto Indirection = DirectValue;
   if (!IGM.IRGen.Opts.DisableDebuggerShadowCopies &&

test/IRGen/async/debug.swift

@@ -0,0 +1,14 @@
+// RUN: %target-swift-frontend -primary-file %s -emit-ir -enable-experimental-concurrency -g | %FileCheck %s
+
+// Don't assert on dynamically sized variables.
+// CHECK: define{{( dllexport)?}}{{( protected)?}} swiftcc void @"$s5debug1fyxxYKlF"
+
+public func f<Success>(_ value: Success) async throws -> Success {
+  switch Result<Success, Error>.success(value) {
+    case .success(let success):
+    return success
+
+  case .failure(let error):
+    throw error;
+  }
+}