Skip to content

Commit a10d98e

Browse files
committed
Fix Python tests for new build flag
1 parent 48399af commit a10d98e

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

utils/build_swift/build_swift/driver_arguments.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -985,10 +985,11 @@ def create_argument_parser():
985985

986986
option('--build-swift-stdlib-static-print', toggle_true,
987987
help='Build constant_vprintf support')
988-
988+
989989
option('--build-swift-stdlib-unicode-data', toggle_true,
990990
default=True,
991-
help='Include Unicode data in the standard library. Note: required for full String functionality')
991+
help='Include Unicode data in the standard library.'
992+
'Note: required for full String functionality')
992993

993994
option(['-S', '--skip-build'], store_true,
994995
help='generate build directory only without building')

utils/build_swift/tests/expected_options.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
'build_swift_static_stdlib': False,
8585
'build_swift_stdlib_unittest_extra': False,
8686
'build_swift_stdlib_static_print': False,
87+
'build_swift_stdlib_unicode_data': True,
8788
'build_swiftpm': False,
8889
'build_swift_driver': False,
8990
'build_early_swift_driver': True,

utils/swift_build_support/swift_build_support/products/swift.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def __init__(self, args, toolchain, source_dir, build_dir):
6363
self.cmake_options.extend(self._freestanding_is_darwin)
6464

6565
self.cmake_options.extend(self._build_swift_private_stdlib)
66-
66+
6767
self.cmake_options.extend(self._enable_stdlib_unicode_data)
6868

6969
@classmethod
@@ -169,7 +169,7 @@ def _enable_experimental_distributed(self):
169169
def _enable_stdlib_static_vprintf(self):
170170
return [('SWIFT_STDLIB_STATIC_PRINT',
171171
self.args.build_swift_stdlib_static_print)]
172-
172+
173173
@property
174174
def _enable_stdlib_unicode_data(self):
175175
return [('SWIFT_STDLIB_ENABLE_UNICODE_DATA',

utils/swift_build_support/tests/products/test_swift.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def setUp(self):
6262
enable_experimental_concurrency=False,
6363
enable_experimental_distributed=False,
6464
build_swift_stdlib_static_print=False,
65-
stdlib_unicode_data=True,
65+
build_swift_stdlib_unicode_data=True,
6666
swift_freestanding_is_darwin=False,
6767
build_swift_private_stdlib=True)
6868

@@ -101,6 +101,7 @@ def test_by_default_no_cmake_options(self):
101101
'-DSWIFT_STDLIB_STATIC_PRINT=FALSE',
102102
'-DSWIFT_FREESTANDING_IS_DARWIN:BOOL=FALSE',
103103
'-DSWIFT_STDLIB_BUILD_PRIVATE:BOOL=TRUE',
104+
'-DSWIFT_STDLIB_ENABLE_UNICODE_DATA=TRUE',
104105
]
105106
self.assertEqual(set(swift.cmake_options), set(expected))
106107

@@ -122,6 +123,7 @@ def test_swift_runtime_tsan(self):
122123
'-DSWIFT_STDLIB_STATIC_PRINT=FALSE',
123124
'-DSWIFT_FREESTANDING_IS_DARWIN:BOOL=FALSE',
124125
'-DSWIFT_STDLIB_BUILD_PRIVATE:BOOL=TRUE',
126+
'-DSWIFT_STDLIB_ENABLE_UNICODE_DATA=TRUE',
125127
]
126128
self.assertEqual(set(swift.cmake_options), set(flags_set))
127129

0 commit comments

Comments
 (0)