tbs

Author: rintaro

lib/AST/Decl.cpp

@@ -8703,7 +8703,7 @@ ParamDecl *ParamDecl::createParsed(
       // TODO: However, we may want to retain its location for diagnostics.
       defaultValue = nullptr;
     }
-    assert(defaultValueInitContext);
+    ASSERT(defaultValueInitContext);
     decl->setDefaultExpr(defaultValue);
     decl->setDefaultArgumentKind(kind);
     if (defaultValue)
@@ -9251,7 +9251,7 @@ ParamDecl::setDefaultValueStringRepresentation(StringRef stringRepresentation) {
 }
 
 void DefaultArgumentInitializer::changeFunction(DeclContext *parent) {
-  assert(parent->isLocalContext());
+  ASSERT(parent->isLocalContext());
   setParent(parent);
 }
 

lib/ASTGen/Sources/ASTGen/ParameterClause.swift

@@ -156,8 +156,8 @@ extension ASTGenVisitor {
     let initContext: BridgedDefaultArgumentInitializer?
     let initExpr: BridgedExpr?
     if let defaultValue = node.defaultValue {
-      // Create the initializer context with the current context (not the function).
-      // The context will be
+      // Create the initializer using the current DeclContext (not the function).
+      // The context will be reset to the function later via 'ParameterList::setDeclContextOfParamDecls()'.
       initContext = BridgedDefaultArgumentInitializer.create(declContext: self.declContext, index: index)
       initExpr = self.withDeclContext(initContext!.asDeclContext) {
         self.generate(expr: defaultValue.value)
@@ -167,6 +167,7 @@ extension ASTGenVisitor {
       initExpr = nil
     }
 
+    // The decl context will be reset to the function later.
     let param = BridgedParamDecl.createParsed(
       self.ctx,
       declContext: self.declContext,
@@ -218,6 +219,7 @@ extension ASTGenVisitor {
     for context: ParameterContext
   ) -> BridgedParameterList {
     var params: [BridgedParamDecl] = []
+    params.reserveCapacity(node.parameters.count)
     for (index, node) in node.parameters.enumerated() {
       let param = self.generate(functionParameter: node, for: context, at: index)
       params.append(param)
@@ -233,6 +235,7 @@ extension ASTGenVisitor {
 
   func generate(enumCaseParameterClause node: EnumCaseParameterClauseSyntax) -> BridgedParameterList {
     var params: [BridgedParamDecl] = []
+    params.reserveCapacity(node.parameters.count)
     for (index, node) in node.parameters.enumerated() {
       let param = self.generate(enumCaseParameter: node, at: index)
       params.append(param)
@@ -270,7 +273,7 @@ extension ASTGenVisitor {
 
   func generate(closureParameterClause node: ClosureParameterClauseSyntax) -> BridgedParameterList {
     var params: [BridgedParamDecl] = []
-
+    params.reserveCapacity(node.parameters.count)
     for (index, node) in node.parameters.enumerated() {
       let param = self.generate(closureParameter: node, at: index)
       param.setSpecifier(.default)