skip loading comment ranges if one of them was invalid

QuietMisdreavus · QuietMisdreavus · commit a69813f7684b · 2021-02-12T11:03:38.000-07:00
diff --git a/lib/AST/RawComment.cpp b/lib/AST/RawComment.cpp
@@ -156,6 +156,11 @@ RawComment Decl::getRawComment(bool SerializedOK) const {
           for (const auto &Range : CachedLocs->DocRanges) {
             if (Range.isValid()) {
               SRCs.push_back({ Range, Context.SourceMgr });
+            } else {
+              // if we've run into an invalid range, don't bother trying to load any of
+              // the other comments
+              SRCs.clear();
+              break;
             }
           }
           auto RC = RawComment(Context.AllocateCopy(llvm::makeArrayRef(SRCs)));

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,11 @@ RawComment Decl::getRawComment(bool SerializedOK) const {`
`156`	`156`	`for (const auto &Range : CachedLocs->DocRanges) {`
`157`	`157`	`if (Range.isValid()) {`
`158`	`158`	`SRCs.push_back({ Range, Context.SourceMgr });`
	`159`	`+ } else {`
	`160`	`+ // if we've run into an invalid range, don't bother trying to load any of`
	`161`	`+ // the other comments`
	`162`	`+ SRCs.clear();`
	`163`	`+ break;`
`159`	`164`	`}`
`160`	`165`	`}`
`161`	`166`	`auto RC = RawComment(Context.AllocateCopy(llvm::makeArrayRef(SRCs)));`